Skip to content

Conversation

@bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 4, 2025

Make sure to visit each request to try collecting metadata for unfinished requests, in case curl_multi_info_read was not polled to the end.

(Test outstanding.)

Make sure to visit each request to try collecting metadata for unfinished requests, in case curl_multi_info_read was not polled to the end.
@bwoebi bwoebi requested a review from a team as a code owner November 4, 2025 21:42
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.86%. Comparing base (50ce39c) to head (33906f5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3469      +/-   ##
==========================================
- Coverage   61.90%   61.86%   -0.05%     
==========================================
  Files         142      142              
  Lines       12895    12895              
  Branches     1689     1689              
==========================================
- Hits         7983     7977       -6     
- Misses       4153     4161       +8     
+ Partials      759      757       -2     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ce39c...33906f5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Nov 4, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-11-04 22:47:00

Comparing candidate commit 33906f5 in PR branch bob/try-collect-curl with baseline commit 50ce39c in branch master.

Found 2 performance improvements and 6 performance regressions! Performance is the same for 186 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1473.287ns; -326.713ns] or [-10.754%; -2.385%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+2.099µs; +4.101µs] or [+2.036%; +3.976%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+3.661µs; +5.559µs] or [+3.474%; +5.275%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+10.087µs; +13.943µs] or [+3.873%; +5.354%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+9.299µs; +14.535µs] or [+3.556%; +5.559%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+47.170µs; +84.019µs] or [+4.491%; +8.000%]

scenario:SpanBench/benchDatadogAPI

  • 🟥 execution_time [+1.588µs; +3.526µs] or [+2.530%; +5.619%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-32.696µs; -20.704µs] or [-7.387%; -4.678%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants