-
Notifications
You must be signed in to change notification settings - Fork 443
fix(configurations): correctly parse payload_tagging_services
[backport 2.21]
#12440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previously this: ```python "payload_tagging_services": set( os.getenv("DD_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES", default={"s3", "sns", "sqs", "kinesis", "eventbridge"}) ), ``` would require users to do `config.botocore["payload_tagging_services"].add("SERVICE_HERE")` as `os.getenv` just returns `string`. If someone were to do: ```powershell $env:DD_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES = "foo,bar" ``` it would be converted into the `set` of `{'o', 'b', 'r', 'f', ',', 'a'}` This correctly parses it as a set of `{"foo", "bar"}` while also stripping any potential whitespace. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Joey Zhao <[email protected]> (cherry picked from commit 6e58426)
Datadog ReportBranch report: ✅ 0 Failed, 650 Passed, 858 Skipped, 7m 42.57s Total Time |
|
BenchmarksBenchmark execution time: 2025-02-24 16:40:51 Comparing candidate commit 94d041b in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 417 metrics, 2 unstable metrics. scenario:iast_aspects-ospathjoin_aspect
|
Backport 6e58426 from #12180 to 2.21.
Previously this:
would require users to do
config.botocore["payload_tagging_services"].add("SERVICE_HERE")
asos.getenv
just returnsstring
.If someone were to do:
it would be converted into the
set
of{'o', 'b', 'r', 'f', ',', 'a'}
This correctly parses it as a set of
{"foo", "bar"}
while also stripping any potential whitespace.Checklist
Reviewer Checklist