Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent installation of incompatible envier==0.5.1 (#11286) #12452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamsxs
Copy link

@adamsxs adamsxs commented Feb 20, 2025

Use of EnvVariable._cast attribute (requires envier>=0.5.2) was introduced in commit 48c2a2c, released in 2.15.1, and the requirement for ddtrace was set to ~=0.5 back in early 2024 in 00a7f00. This is generally fine but as seen in the issue #11286 it's still occasionally possible to end up with envier==0.5.1 in your environment and cause ddtrace to fail.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@adamsxs adamsxs requested a review from a team as a code owner February 20, 2025 20:19
@adamsxs adamsxs requested a review from tabgok February 20, 2025 20:19
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 21, 2025
@adamsxs
Copy link
Author

adamsxs commented Feb 21, 2025

System Tests appear to be failing due to an unset You must set an DD_API_KEY environment variable to run the Datadog Agent container. I noticed that field was blank in one of the build steps: https://github.com/DataDog/dd-trace-py/actions/runs/13460183428/job/37613373156?pr=12452#step:4:7
Forgive the ignorance here, first time contributing to the repo and still learning Github Actions. I'll re-base the base branch just in case, but if there's a lookup on something I should be setting please let me know.

Use of EnvVariable._cast was introduced in commit 48c2a2c, released in 2.15.1, and the requirement for ddtrace
was set to ~=0.5 back in early 2024 in 00a7f00. This is generally fine but as seen in the issue it's sporadically
possible to end up with envier==0.5.1 in your environment and cause ddtrace to fail.
@adamsxs adamsxs force-pushed the fix-envier-incompatible-version branch from a81fb61 to 9ae1783 Compare February 21, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants