-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(internal): add more detail to encoding error message #12455
base: main
Are you sure you want to change the base?
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 149 Passed, 1165 Skipped, 2m 3.5s Total Time |
BenchmarksBenchmark execution time: 2025-02-21 17:25:07 Comparing candidate commit 07335e1 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also change lines 116-117: https://github.com/DataDog/dd-trace-py/pull/12455/files#diff-23840af0f4cae717d33e76ce1d0f4766fcc2e1f46a52e9716f6632d984ddfb4cL116-L117
except OverflowError as oe:
raise OverflowError("Integer value out of range: %d" % n)
Left a non-blocking suggestion! |
Checklist
Reviewer Checklist