Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal): add more detail to encoding error message #12455

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rachelyangdog
Copy link
Contributor

@rachelyangdog rachelyangdog commented Feb 20, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@rachelyangdog rachelyangdog requested a review from a team as a code owner February 20, 2025 21:21
Copy link
Contributor

github-actions bot commented Feb 20, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/_encoding.pyx                                          @DataDog/apm-core-python
tests/tracer/test_encoders.py                                           @DataDog/apm-sdk-api-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Feb 20, 2025

Datadog Report

Branch report: rachel.yang/add-pprint-log
Commit report: 07335e1
Test service: dd-trace-py

✅ 0 Failed, 149 Passed, 1165 Skipped, 2m 3.5s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2025

Benchmarks

Benchmark execution time: 2025-02-21 17:25:07

Comparing candidate commit 07335e1 in PR branch rachel.yang/add-pprint-log with baseline commit 7011d3c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@emmettbutler emmettbutler changed the title adding more detail to encoding error message chore(internal): add more detail to encoding error message Feb 21, 2025
@rachelyangdog rachelyangdog added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 21, 2025
@rachelyangdog rachelyangdog requested a review from a team as a code owner February 21, 2025 16:42
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also change lines 116-117: https://github.com/DataDog/dd-trace-py/pull/12455/files#diff-23840af0f4cae717d33e76ce1d0f4766fcc2e1f46a52e9716f6632d984ddfb4cL116-L117

        except OverflowError as oe:
            raise OverflowError("Integer value out of range: %d" % n)

@quinna-h
Copy link
Contributor

Left a non-blocking suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants