Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(botocore): remove flaky decorator from botocore test #12456

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Feb 20, 2025

Remove an unnecessary @flaky decorator from the botocore test: test_aws_payload_tagging_s3_invalid_config

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@quinna-h quinna-h changed the title remove flaky decorator from botocore test chore(ci): remove flaky decorator from botocore test Feb 20, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/botocore/test.py                                          @DataDog/apm-core-python @DataDog/apm-idm-python

@quinna-h quinna-h marked this pull request as ready for review February 20, 2025 22:01
@quinna-h quinna-h requested review from a team as code owners February 20, 2025 22:01
@quinna-h quinna-h requested review from juanjux and wconti27 February 20, 2025 22:01
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: quinna.halim/remove-flaky-from-botocore
Commit report: 246d0e4
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 1m 39.28s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2025

Benchmarks

Benchmark execution time: 2025-02-21 21:23:58

Comparing candidate commit 1268431 in PR branch quinna.halim/remove-flaky-from-botocore with baseline commit 7011d3c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@emmettbutler emmettbutler changed the title chore(ci): remove flaky decorator from botocore test ci(botocore): remove flaky decorator from botocore test Feb 21, 2025
@emmettbutler emmettbutler changed the title ci(botocore): remove flaky decorator from botocore test test(botocore): remove flaky decorator from botocore test Feb 21, 2025
@quinna-h quinna-h added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 21, 2025
@quinna-h quinna-h enabled auto-merge (squash) February 21, 2025 20:42
@quinna-h quinna-h merged commit f8fe2b8 into main Feb 21, 2025
316 of 317 checks passed
@quinna-h quinna-h deleted the quinna.halim/remove-flaky-from-botocore branch February 21, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants