Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix django flaky tests as of Feb 2025 #12458

Closed
wants to merge 8 commits into from

Conversation

wantsui
Copy link
Collaborator

@wantsui wantsui commented Feb 20, 2025

Many of the Django tests were marked with expired flaky time stamps.
This PR attempts to fix that.

Tests:

  • test_cached_template - I extended the flaky timestamp unless I think of an easy way to force the Django view to cache twice consistently. Weirdly enough, it only flakes when the entire CI runs but not if you run this specific test individually.
  • test_psycopg3_query_default - For some reason, this test fails sometimes because the pq module is not available. I'm currently waiting for the CI to run all the variations to see if this works.
  • test_urlpatterns_include - fixed incorrect service name
  • test_cached_template - fixed incorrect service name

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@wantsui wantsui requested a review from quinna-h February 20, 2025 22:10
Copy link
Contributor

github-actions bot commented Feb 20, 2025

CODEOWNERS have been resolved as:

tests/contrib/django/test_django.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/django/test_django_snapshots.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_psycopg3_query_default.json  @DataDog/apm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_urlpatterns_include.json  @DataDog/apm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: wantsui/fix-django-flaky
Commit report: 23b907e
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 1m 29.44s Total Time

@wantsui wantsui changed the title chore: fix django flaky tests chore: fix django flaky tests as of Feb 2024 Feb 20, 2025
@wantsui wantsui added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 20, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2025

Benchmarks

Benchmark execution time: 2025-02-21 14:40:41

Comparing candidate commit b722fb6 in PR branch wantsui/fix-django-flaky with baseline commit 9b30e2b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@wantsui
Copy link
Collaborator Author

wantsui commented Feb 21, 2025

Closing due to #12474 already tackling this.

@wantsui wantsui closed this Feb 21, 2025
@wantsui wantsui changed the title chore: fix django flaky tests as of Feb 2024 chore: fix django flaky tests as of Feb 2025 Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant