Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): extend timestamp on flaky test decorator for grpc #12461

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Feb 20, 2025

Extend flaky expiration date for flaky grpc test until 1767220930 (12/31/25)

notes:
If gitlab does not support ipv6, and we do not when this will change, long-term we should either

  1. change to use a different protocol that is supported
  2. remove the test entirely

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Feb 20, 2025

CODEOWNERS have been resolved as:

tests/contrib/grpc/test_grpc.py                                         @DataDog/apm-idm-python @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2025

Benchmarks

Benchmark execution time: 2025-02-21 22:51:34

Comparing candidate commit 820a713 in PR branch quinna.halim/grpc-flaky-test with baseline commit 6bf9381 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@quinna-h quinna-h marked this pull request as ready for review February 21, 2025 14:21
@quinna-h quinna-h requested a review from wantsui February 21, 2025 20:27
@quinna-h quinna-h requested review from a team as code owners February 21, 2025 22:05
@quinna-h quinna-h requested a review from wantsui February 21, 2025 22:05
Copy link
Collaborator

@wantsui wantsui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 let's hope they add support eventually

@quinna-h quinna-h added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 21, 2025
@quinna-h quinna-h enabled auto-merge (squash) February 21, 2025 22:20
@quinna-h quinna-h merged commit 70b09cc into main Feb 21, 2025
321 of 324 checks passed
@quinna-h quinna-h deleted the quinna.halim/grpc-flaky-test branch February 21, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants