-
Notifications
You must be signed in to change notification settings - Fork 467
feat: add span pointer attributes for websocket context propagation #15153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 5 ms. The average import time from base is: 248 ± 5 ms. The import time difference between this PR and base is: -1.4 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate quinna.halim/websocket-context-propagation (a399cdd) with baseline main (7bc20af) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: ~same Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +2.9% ✅ add_inplace_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.5% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +2.9% ✅ add_inplace_noaspectTime: ✅ 0.321µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +1.3% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +3.2% ✅ add_noaspectTime: ✅ 0.279µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.6% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +3.1% ✅ bytearray_aspectTime: ✅ 1.324µs (SLO: <10.000µs 📉 -86.8%) vs baseline: -1.0% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +2.9% ✅ bytearray_extend_aspectTime: ✅ 1.525µs (SLO: <10.000µs 📉 -84.8%) vs baseline: -0.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +3.0% ✅ bytearray_extend_noaspectTime: ✅ 0.611µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -1.5% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +3.1% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.2% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +2.9% ✅ bytes_aspectTime: ✅ 1.283µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -0.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +3.1% ✅ bytes_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.7% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.2% ✅ bytesio_aspectTime: ✅ 1.306µs (SLO: <10.000µs 📉 -86.9%) vs baseline: -0.6% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.0% ✅ bytesio_noaspectTime: ✅ 0.500µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.0% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +3.0% ✅ capitalize_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.9% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.1% ✅ capitalize_noaspectTime: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.3% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +2.8% ✅ casefold_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.4% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +3.1% ✅ casefold_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.5% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +3.2% ✅ decode_aspectTime: ✅ 0.725µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.0% ✅ decode_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.1% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.1% ✅ encode_aspectTime: ✅ 0.709µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.2% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +3.2% ✅ encode_noaspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.2% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +2.7% ✅ format_aspectTime: ✅ 3.296µs (SLO: <10.000µs 📉 -67.0%) vs baseline: -2.0% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +2.7% ✅ format_map_aspectTime: ✅ 3.609µs (SLO: <10.000µs 📉 -63.9%) vs baseline: +3.5% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.0% ✅ format_map_noaspectTime: ✅ 0.776µs (SLO: <10.000µs 📉 -92.2%) vs baseline: -0.1% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +2.9% ✅ format_noaspectTime: ✅ 0.592µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.7% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +3.0% ✅ index_aspectTime: ✅ 0.359µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.8% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +3.2% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.6% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +2.7% ✅ join_aspectTime: ✅ 1.358µs (SLO: <10.000µs 📉 -86.4%) vs baseline: -0.4% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +3.0% ✅ join_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.1% ✅ ljust_aspectTime: ✅ 2.527µs (SLO: <20.000µs 📉 -87.4%) vs baseline: +0.4% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +2.7% ✅ ljust_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.3% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +3.0% ✅ lower_aspectTime: ✅ 2.205µs (SLO: <10.000µs 📉 -77.9%) vs baseline: +0.4% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +2.7% ✅ lower_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +3.1% ✅ lstrip_aspectTime: ✅ 2.241µs (SLO: <20.000µs 📉 -88.8%) vs baseline: -0.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +3.1% ✅ lstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.4% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +3.4% ✅ modulo_aspectTime: ✅ 1.048µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +0.2% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +2.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.554µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.5% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +2.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.986µs (SLO: <10.000µs 📉 -90.1%) vs baseline: +0.4% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +3.2% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.260µs (SLO: <10.000µs 📉 -87.4%) vs baseline: +0.8% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +3.2% ✅ modulo_noaspectTime: ✅ 0.623µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -0.4% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +3.0% ✅ replace_aspectTime: ✅ 5.418µs (SLO: <10.000µs 📉 -45.8%) vs baseline: 📈 +12.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.2% ✅ replace_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.0% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +2.8% ✅ repr_aspectTime: ✅ 0.904µs (SLO: <10.000µs 📉 -91.0%) vs baseline: ~same Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +3.2% ✅ repr_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.4% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +3.1% ✅ rstrip_aspectTime: ✅ 1.886µs (SLO: <20.000µs 📉 -90.6%) vs baseline: +0.2% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +3.2% ✅ rstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.6% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.0% ✅ slice_aspectTime: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +3.2% ✅ slice_noaspectTime: ✅ 0.446µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.7% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +3.0% ✅ stringio_aspectTime: ✅ 1.519µs (SLO: <10.000µs 📉 -84.8%) vs baseline: -0.5% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +2.9% ✅ stringio_noaspectTime: ✅ 0.718µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.8% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +2.8% ✅ strip_aspectTime: ✅ 2.232µs (SLO: <20.000µs 📉 -88.8%) vs baseline: ~same Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +3.2% ✅ strip_noaspectTime: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: ~same Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.4% ✅ swapcase_aspectTime: ✅ 2.398µs (SLO: <10.000µs 📉 -76.0%) vs baseline: -0.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +2.7% ✅ swapcase_noaspectTime: ✅ 0.535µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.4% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +3.1% ✅ title_aspectTime: ✅ 2.339µs (SLO: <10.000µs 📉 -76.6%) vs baseline: ~same Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +2.9% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.1% ✅ translate_aspectTime: ✅ 3.366µs (SLO: <10.000µs 📉 -66.3%) vs baseline: +4.1% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +2.9% ✅ translate_noaspectTime: ✅ 1.044µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +3.0% ✅ upper_aspectTime: ✅ 2.208µs (SLO: <10.000µs 📉 -77.9%) vs baseline: -0.2% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +3.3% ✅ upper_noaspectTime: ✅ 0.375µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.9% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +3.0% 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.503ms (SLO: <22.300ms -8.1%) vs baseline: +0.3% Memory: ✅ 66.044MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.7% ✅ exception-replay-enabledTime: ✅ 1.340ms (SLO: <1.450ms -7.6%) vs baseline: +0.3% Memory: ✅ 64.240MB (SLO: <67.000MB -4.1%) vs baseline: +4.8% ✅ iastTime: ✅ 20.423ms (SLO: <22.250ms -8.2%) vs baseline: ~same Memory: ✅ 66.059MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.6% ✅ profilerTime: ✅ 15.512ms (SLO: <16.550ms -6.3%) vs baseline: -0.3% Memory: ✅ 54.118MB (SLO: <54.500MB 🟡 -0.7%) vs baseline: +5.2% ✅ resource-renamingTime: ✅ 20.546ms (SLO: <21.750ms -5.5%) vs baseline: +0.1% Memory: ✅ 66.218MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.331ms (SLO: <28.200ms 📉 -10.2%) vs baseline: -0.3% Memory: ✅ 67.086MB (SLO: <69.500MB -3.5%) vs baseline: +4.5% ✅ tracerTime: ✅ 20.423ms (SLO: <21.750ms -6.1%) vs baseline: ~same Memory: ✅ 66.056MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.648ms (SLO: <23.500ms -3.6%) vs baseline: -0.2% Memory: ✅ 67.753MB (SLO: <68.000MB 🟡 -0.4%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.289ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.2% Memory: ✅ 66.000MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.674ms (SLO: <17.500ms -4.7%) vs baseline: +0.4% Memory: ✅ 65.966MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.505ms (SLO: <21.750ms -5.7%) vs baseline: +0.4% Memory: ✅ 67.771MB (SLO: <72.500MB -6.5%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.482ms (SLO: <19.650ms -5.9%) vs baseline: +0.4% Memory: ✅ 66.044MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.823ms (SLO: <20.100ms -6.4%) vs baseline: +0.5% Memory: ✅ 65.966MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.166ms (SLO: <21.500ms -6.2%) vs baseline: ~same Memory: ✅ 66.025MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.6% ✅ tracer-no-templatesTime: ✅ 20.348ms (SLO: <22.000ms -7.5%) vs baseline: -0.2% Memory: ✅ 66.008MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.6% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.025ms (SLO: <19.850ms -9.2%) vs baseline: -0.3% Memory: ✅ 66.198MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.092ms (SLO: <19.400ms -6.7%) vs baseline: +0.3% Memory: ✅ 66.211MB (SLO: <66.500MB 🟡 -0.4%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 18.065ms (SLO: <19.450ms -7.1%) vs baseline: +0.3% Memory: ✅ 65.805MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +4.7% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.071ms (SLO: <2.300ms -10.0%) vs baseline: +0.2% Memory: ✅ 52.652MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 2.077ms (SLO: <2.250ms -7.7%) vs baseline: ~same Memory: ✅ 52.612MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 2.075ms (SLO: <2.300ms -9.8%) vs baseline: +0.4% Memory: ✅ 52.612MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.595ms (SLO: <4.750ms -3.3%) vs baseline: ~same Memory: ✅ 62.302MB (SLO: <65.000MB -4.2%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.637ms (SLO: <6.750ms 🟡 -1.7%) vs baseline: ~same Memory: ✅ 62.436MB (SLO: <65.000MB -3.9%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.597ms (SLO: <4.750ms -3.2%) vs baseline: +0.3% Memory: ✅ 62.408MB (SLO: <65.000MB -4.0%) vs baseline: +5.0% ✅ debuggerTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 45.373MB (SLO: <47.000MB -3.5%) vs baseline: +5.3% ✅ iast-getTime: ✅ 1.872ms (SLO: <2.000ms -6.4%) vs baseline: +0.8% Memory: ✅ 42.127MB (SLO: <49.000MB 📉 -14.0%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -9.0%) vs baseline: ~same Memory: ✅ 46.699MB (SLO: <47.000MB 🟡 -0.6%) vs baseline: +4.4% ✅ resource-renamingTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: -0.4% Memory: ✅ 52.579MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.350ms (SLO: <3.650ms -8.2%) vs baseline: +0.2% Memory: ✅ 52.549MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.348ms (SLO: <3.650ms -8.3%) vs baseline: +0.2% Memory: ✅ 54.026MB (SLO: <60.000MB -10.0%) vs baseline: +4.7% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.962ms (SLO: <4.200ms -5.7%) vs baseline: -0.2% Memory: ✅ 62.443MB (SLO: <66.000MB -5.4%) vs baseline: +4.9% ✅ iast-enabledTime: ✅ 2.439ms (SLO: <2.800ms 📉 -12.9%) vs baseline: -0.1% Memory: ✅ 58.805MB (SLO: <60.000MB 🟡 -2.0%) vs baseline: +4.3% ✅ tracer-enabledTime: ✅ 2.054ms (SLO: <2.250ms -8.7%) vs baseline: +0.3% Memory: ✅ 52.691MB (SLO: <54.500MB -3.3%) vs baseline: +4.9% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 309.600ms (SLO: <320.950ms -3.5%) vs baseline: +0.3% Memory: ✅ 32.755MB (SLO: <34.500MB -5.1%) vs baseline: +4.7% ✅ deep-profiledTime: ✅ 328.537ms (SLO: <359.150ms -8.5%) vs baseline: +0.3% Memory: ✅ 38.574MB (SLO: <39.000MB 🟡 -1.1%) vs baseline: +6.0% ✅ mediumTime: ✅ 7.035ms (SLO: <7.400ms -4.9%) vs baseline: +0.5% Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.3% ✅ shallowTime: ✅ 0.939ms (SLO: <1.050ms 📉 -10.5%) vs baseline: ~same Memory: ✅ 32.008MB (SLO: <34.000MB -5.9%) vs baseline: +5.1%
|
Description
Add span pointer attributes to the span links for websocket context propagation
RFC
Testing
Risks
Additional Notes