-
Notifications
You must be signed in to change notification settings - Fork 467
chore(tracing): deprecate Span.finished setter and Span.finish_with_ancestors() #15187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Yun-Kim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo in release note but lgtm
releasenotes/notes/deprecate-span-finished-finish-with-ancestors-c75633a9baaa9463.yaml
Outdated
Show resolved
Hide resolved
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 4 ms. The average import time from base is: 253 ± 5 ms. The import time difference between this PR and base is: -6.1 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
…rs-c75633a9baaa9463.yaml Co-authored-by: Yun Kim <[email protected]>
Performance SLOsComparing candidate brettlangdon/deprecate.span (6aa47f3) with baseline main (1f1ac6a) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.1% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.2% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.6% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -0.1% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.3% ✅ bytearray_aspectTime: ✅ 1.308µs (SLO: <10.000µs 📉 -86.9%) vs baseline: -1.0% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ bytearray_extend_aspectTime: ✅ 1.478µs (SLO: <10.000µs 📉 -85.2%) vs baseline: +0.2% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.608µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.4% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.483µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.2% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 1.431µs (SLO: <10.000µs 📉 -85.7%) vs baseline: 📈 +11.3% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ bytesio_aspectTime: ✅ 1.316µs (SLO: <10.000µs 📉 -86.8%) vs baseline: -1.2% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -1.0% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ capitalize_aspectTime: ✅ 0.733µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.0% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +5.0% ✅ capitalize_noaspectTime: ✅ 0.435µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.2% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 0.732µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.8% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.1% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ decode_aspectTime: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.8% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +5.0% ✅ decode_noaspectTime: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.6% ✅ encode_aspectTime: ✅ 0.713µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.2% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ encode_noaspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.3% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.353µs (SLO: <10.000µs 📉 -66.5%) vs baseline: -0.8% Memory: ✅ 37.120MB (SLO: <39.000MB -4.8%) vs baseline: +4.6% ✅ format_map_aspectTime: ✅ 3.685µs (SLO: <10.000µs 📉 -63.2%) vs baseline: +2.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.2% ✅ format_map_noaspectTime: ✅ 0.776µs (SLO: <10.000µs 📉 -92.2%) vs baseline: ~same Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 0.599µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.7% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ index_aspectTime: ✅ 0.357µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.9% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.6% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.4% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 1.341µs (SLO: <10.000µs 📉 -86.6%) vs baseline: -1.1% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ join_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.1% ✅ ljust_aspectTime: ✅ 2.625µs (SLO: <20.000µs 📉 -86.9%) vs baseline: ~same Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ ljust_noaspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.4% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 2.202µs (SLO: <10.000µs 📉 -78.0%) vs baseline: +0.3% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 0.365µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -1.2% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 2.525µs (SLO: <20.000µs 📉 -87.4%) vs baseline: 📈 +13.1% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.2% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 1.000µs (SLO: <10.000µs 📉 -90.0%) vs baseline: +0.6% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.544µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +0.6% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.979µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.5% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.208µs (SLO: <10.000µs 📉 -87.9%) vs baseline: +0.7% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 0.626µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.6% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 4.830µs (SLO: <10.000µs 📉 -51.7%) vs baseline: -0.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 0.460µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.6% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 0.908µs (SLO: <10.000µs 📉 -90.9%) vs baseline: -0.3% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.6% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.942µs (SLO: <20.000µs 📉 -90.3%) vs baseline: +0.2% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.1% ✅ rstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.9% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.1% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +5.1% ✅ slice_noaspectTime: ✅ 0.448µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.2% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ stringio_aspectTime: ✅ 1.723µs (SLO: <10.000µs 📉 -82.8%) vs baseline: 📈 +10.9% Memory: ✅ 37.120MB (SLO: <39.000MB -4.8%) vs baseline: +4.5% ✅ stringio_noaspectTime: ✅ 0.722µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.6% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ strip_aspectTime: ✅ 2.230µs (SLO: <20.000µs 📉 -88.8%) vs baseline: -0.5% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ strip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.6% Memory: ✅ 37.159MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 2.419µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +0.6% Memory: ✅ 37.139MB (SLO: <39.000MB -4.8%) vs baseline: +4.6% ✅ swapcase_noaspectTime: ✅ 0.538µs (SLO: <10.000µs 📉 -94.6%) vs baseline: -0.2% Memory: ✅ 37.198MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 2.337µs (SLO: <10.000µs 📉 -76.6%) vs baseline: -0.7% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.8% ✅ title_noaspectTime: ✅ 0.504µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ translate_aspectTime: ✅ 3.263µs (SLO: <10.000µs 📉 -67.4%) vs baseline: +0.7% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +5.1% ✅ translate_noaspectTime: ✅ 1.044µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.4% Memory: ✅ 37.179MB (SLO: <39.000MB -4.7%) vs baseline: +4.7% ✅ upper_aspectTime: ✅ 2.229µs (SLO: <10.000µs 📉 -77.7%) vs baseline: +1.2% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +5.0% ✅ upper_noaspectTime: ✅ 0.375µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.2% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.465ms (SLO: <22.300ms -8.2%) vs baseline: -0.2% Memory: ✅ 66.123MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ exception-replay-enabledTime: ✅ 1.339ms (SLO: <1.450ms -7.6%) vs baseline: -0.6% Memory: ✅ 64.264MB (SLO: <67.000MB -4.1%) vs baseline: +4.9% ✅ iastTime: ✅ 20.452ms (SLO: <22.250ms -8.1%) vs baseline: -0.3% Memory: ✅ 66.158MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.532ms (SLO: <16.550ms -6.2%) vs baseline: ~same Memory: ✅ 54.076MB (SLO: <54.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 20.556ms (SLO: <21.750ms -5.5%) vs baseline: -0.2% Memory: ✅ 66.178MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.367ms (SLO: <28.200ms 📉 -10.0%) vs baseline: -0.3% Memory: ✅ 67.350MB (SLO: <69.500MB -3.1%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.470ms (SLO: <21.750ms -5.9%) vs baseline: -0.2% Memory: ✅ 66.100MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-and-profilerTime: ✅ 22.689ms (SLO: <23.500ms -3.5%) vs baseline: ~same Memory: ✅ 67.928MB (SLO: <68.000MB 🟡 -0.1%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.304ms (SLO: <21.500ms 📉 -10.2%) vs baseline: -0.2% Memory: ✅ 66.099MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.642ms (SLO: <17.500ms -4.9%) vs baseline: -0.3% Memory: ✅ 66.164MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.2% ✅ tracer-nativeTime: ✅ 20.464ms (SLO: <21.750ms -5.9%) vs baseline: -0.2% Memory: ✅ 68.007MB (SLO: <72.500MB -6.2%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 18.489ms (SLO: <19.650ms -5.9%) vs baseline: -0.2% Memory: ✅ 66.123MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.771ms (SLO: <20.100ms -6.6%) vs baseline: ~same Memory: ✅ 65.893MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.139ms (SLO: <21.500ms -6.3%) vs baseline: ~same Memory: ✅ 66.227MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ tracer-no-templatesTime: ✅ 20.283ms (SLO: <22.000ms -7.8%) vs baseline: -0.1% Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.053ms (SLO: <19.850ms -9.1%) vs baseline: ~same Memory: ✅ 66.178MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.091ms (SLO: <19.400ms -6.7%) vs baseline: +0.5% Memory: ✅ 66.178MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 18.057ms (SLO: <19.450ms -7.2%) vs baseline: -0.4% Memory: ✅ 65.746MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +4.5% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.071ms (SLO: <2.300ms -10.0%) vs baseline: +0.3% Memory: ✅ 52.593MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ errortracking-enabled-userTime: ✅ 2.073ms (SLO: <2.250ms -7.9%) vs baseline: +0.5% Memory: ✅ 52.593MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.2% ✅ tracer-enabledTime: ✅ 2.090ms (SLO: <2.300ms -9.1%) vs baseline: +0.8% Memory: ✅ 52.534MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.591ms (SLO: <4.750ms -3.3%) vs baseline: -0.9% Memory: ✅ 62.299MB (SLO: <65.000MB -4.2%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.640ms (SLO: <6.750ms 🟡 -1.6%) vs baseline: +0.4% Memory: ✅ 62.340MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.596ms (SLO: <4.750ms -3.2%) vs baseline: -0.5% Memory: ✅ 62.303MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: -0.5% Memory: ✅ 45.326MB (SLO: <47.000MB -3.6%) vs baseline: +5.1% ✅ iast-getTime: ✅ 1.865ms (SLO: <2.000ms -6.8%) vs baseline: ~same Memory: ✅ 42.043MB (SLO: <49.000MB 📉 -14.2%) vs baseline: +4.7% ✅ profilerTime: ✅ 1.917ms (SLO: <2.100ms -8.7%) vs baseline: -0.4% Memory: ✅ 46.690MB (SLO: <47.000MB 🟡 -0.7%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: -0.3% Memory: ✅ 52.536MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.350ms (SLO: <3.650ms -8.2%) vs baseline: -0.2% Memory: ✅ 52.560MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.355ms (SLO: <3.650ms -8.1%) vs baseline: -0.4% Memory: ✅ 54.393MB (SLO: <60.000MB -9.3%) vs baseline: +4.8% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 308.749ms (SLO: <320.950ms -3.8%) vs baseline: +0.1% Memory: ✅ 32.735MB (SLO: <34.500MB -5.1%) vs baseline: +5.2% ✅ deep-profiledTime: ✅ 328.143ms (SLO: <359.150ms -8.6%) vs baseline: -0.2% Memory: ✅ 38.637MB (SLO: <39.000MB 🟡 -0.9%) vs baseline: +5.8% ✅ mediumTime: ✅ 7.043ms (SLO: <7.400ms -4.8%) vs baseline: +0.4% Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.5% ✅ shallowTime: ✅ 0.940ms (SLO: <1.050ms 📉 -10.5%) vs baseline: -0.2% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.8%
|
Description
A few more Span attributes/methods to deprecate in 4.0.
Testing
Risks
Additional Notes