Skip to content

chore: bytecode strict typing#18165

Open
P403n1x87 wants to merge 2 commits into
mainfrom
chore/bytecode-strict-typing
Open

chore: bytecode strict typing#18165
P403n1x87 wants to merge 2 commits into
mainfrom
chore/bytecode-strict-typing

Conversation

@P403n1x87
Copy link
Copy Markdown
Contributor

Description

We enable strict type checking for bytecode handling modules.

We enable strict type checking for bytecode handling modules.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label May 19, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

ddtrace/debugging/_expressions.py                                       @DataDog/debugger-python
ddtrace/internal/assembly.py                                            @DataDog/apm-core-python
ddtrace/internal/bytecode_injection/__init__.py                         @DataDog/apm-core-python
ddtrace/internal/wrapping/__init__.py                                   @DataDog/apm-core-python
ddtrace/internal/wrapping/asyncs.py                                     @DataDog/apm-core-python
ddtrace/internal/wrapping/context.py                                    @DataDog/apm-core-python
ddtrace/internal/wrapping/generators.py                                 @DataDog/apm-core-python
mypy.ini                                                                @DataDog/python-guild @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 Bot commented May 19, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 11 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64, 1]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). NotImplementedError: This version of CPython is not supported yet

DataDog/apm-reliability/dd-trace-py | build linux: [arm64, cp315-cp315, v113741589-d2b8243-musllinux_1_2_aarch64]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). AssertionError: Failed with DD_IAST_ENABLED=0: 1 during native module load test.

DataDog/apm-reliability/dd-trace-py | check-slo-breaches   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Benchmark analysis failed due to threshold breaches in multiple metrics. Key metric 'max_rss_usage' exceeded expected limits in 20 scenarios.

View all 11 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8fdc3a1 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 19, 2026

Benchmarks

Benchmark execution time: 2026-05-21 14:31:09

Comparing candidate commit 8fdc3a1 in PR branch chore/bytecode-strict-typing with baseline commit 131e904 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 613 metrics, 10 unstable metrics.

scenario:iastaspects-lstrip_aspect

  • 🟥 execution_time [+62.740µs; +67.423µs] or [+23.043%; +24.763%]

scenario:iastaspects-translate_aspect

  • 🟥 execution_time [+57.887µs; +65.009µs] or [+11.681%; +13.117%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+91.559µs; +101.861µs] or [+21.483%; +23.900%]

scenario:span-start

  • 🟥 execution_time [+1.357ms; +1.534ms] or [+8.677%; +9.810%]

@P403n1x87 P403n1x87 marked this pull request as ready for review May 19, 2026 15:19
@P403n1x87 P403n1x87 requested review from a team as code owners May 19, 2026 15:19
@P403n1x87 P403n1x87 requested review from Yun-Kim and juanjux May 19, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants