Skip to content

chore(asyncpg): fix flaky test_execute_after_patch_unpatch_patch #18199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
May 21, 2026
Merged

chore(asyncpg): fix flaky test_execute_after_patch_unpatch_patch #18199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f1f2b9
Stabilize asyncpg patch cycle test setup
datadog-bits May 20, 2026
12c511b
Merge branch 'main' into dd/fix/flaky-asyncpg-patch-cycle-test
quinna-h May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions tests/contrib/asyncpg/test_asyncpg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,11 +414,22 @@ def test_patch_unpatch_patch_cycle():


@pytest.mark.asyncio
async def test_execute_after_patch_unpatch_patch(patched_conn):
async def test_execute_after_patch_unpatch_patch():
# Regression: executing a query must succeed after patch/unpatch/patch.
unpatch()
patch()
await patched_conn.execute("SELECT 1")

conn = await asyncpg.connect(
host=POSTGRES_CONFIG["host"],
port=POSTGRES_CONFIG["port"],
user=POSTGRES_CONFIG["user"],
database=POSTGRES_CONFIG["dbname"],
password=POSTGRES_CONFIG["password"],
)
try:
await conn.execute("SELECT 1")
finally:
await conn.close()


class AsyncPgTestCase(AsyncioTestCase):
Expand Down
Loading