Add new gemfiles to lock-dependency commit #4962
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dev/github
marcotc
added
dev/internal
Typing analysisIgnored filesThere are 539 ignored files in the Steepfile out of 836. Ignored filesNote: Ignored files are excluded from the next sections.
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 4828852 | Docs | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2025-10-08 21:43:54 Comparing candidate commit 4828852 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:tracing - Propagation - Datadog
|
Strech
reviewed
Oct 9, 2025
| path: gemfiles | ||
| pattern: lock-dependency-${{ github.run_id }}-* | ||
| merge-multiple: true | ||
| - name: Stage changes # Since ghcommit-action does not pick up unstaged files |
There was a problem hiding this comment.
I think it should run after git diff, otherwise you need to adjust diff to show staged changes
There was a problem hiding this comment.
git diff will not show staged files, one solution should be git add -u after git add gemfiles and git diff --cached.
There was a problem hiding this comment.
I think a simple order change would do a thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was noticed recently (#4924 (comment)) and it caused by a known limitation of planetscale/ghcommit-action.
Here you can see where our job failed to pick up the newly added gemfile.lock: https://github.com/DataDog/dd-trace-rb/actions/runs/18348438937/job/52262026349#step:7:298
Change log entry
No