Fix http.route
tag for rack apps mounted in Rails
#4988
+30
−137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the behavior that used the request path as a fallback when computing the route for Rack applications mounted inside Rails.
Motivation:
The current approach to setting the http.route tag for mounted Rack applications causes issues for the API Catalog. Specifically, when a mounted Rack application includes parameters in its request path, it can lead to an unbounded number of reported routes.
This issue can occur in the following cases:
Before the fix route for an embedded Rack app would look like
/path/for/mounted/app/users/1
, after the fix it would be/path/for/mounted/app
.Change log entry
Yes. Fix
http.route
tag for Rack applications mounted inside Rails.Additional Notes:
APPSEC-59663
How to test the change?
CI and app generator.