Skip to content

Conversation

y9v
Copy link
Member

@y9v y9v commented Oct 17, 2025

What does this PR do?
This PR removes the behavior that used the request path as a fallback when computing the route for Rack applications mounted inside Rails.

Motivation:
The current approach to setting the http.route tag for mounted Rack applications causes issues for the API Catalog. Specifically, when a mounted Rack application includes parameters in its request path, it can lead to an unbounded number of reported routes.

This issue can occur in the following cases:

  • Mounted applications such as the Sidekiq web UI, which is a Rack app with a simple router.
  • Mounted Sinatra and Grape applications, when the Datadog tracer is configured to instrument Rails but not Sinatra or Grape directly.

Before the fix route for an embedded Rack app would look like /path/for/mounted/app/users/1, after the fix it would be /path/for/mounted/app.

Change log entry
Yes. Fix http.route tag for Rack applications mounted inside Rails.

Additional Notes:
APPSEC-59663

How to test the change?
CI and app generator.

@y9v y9v self-assigned this Oct 17, 2025
@y9v y9v requested review from a team as code owners October 17, 2025 12:58
@y9v y9v requested a review from mabdinur October 17, 2025 12:58
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Oct 17, 2025
@y9v y9v requested review from Strech and mabdinur and removed request for mabdinur October 17, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant