Skip to content

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Oct 17, 2025

(Please ignore this PR, I've added it only so I can share it with folks working on libdatadog)

@github-actions github-actions bot added the profiling Involves Datadog profiling label Oct 17, 2025
@github-actions
Copy link

👋 Hey @ivoanjo, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-10-17 16:13:05 UTC

@ivoanjo
Copy link
Member Author

ivoanjo commented Oct 17, 2025

This is built to match DataDog/libdatadog@eee496c .

The LIBDATADOG_VENDOR_OVERRIDE environment variable can be used to point the Ruby profiler at a different libdatadog branch (more details here).

@datadog-datadog-prod-us1
Copy link
Contributor

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

datadog_ruby_common helpers datadog_ruby_common.h is identical between profiling and libdatadog_api from rspec (Datadog)
datadog_ruby_common.h files are not identical
Diff:
@@ -61,3 +61,9 @@
   ddog_Error_drop(error);
   return result;
 }
+
+static inline VALUE get_status_details_and_drop(ddog_prof_Status *status) {
+  VALUE result = rb_str_new_cstr(status->err);
+  ddog_prof_Status_drop(status);
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9977407 | Docs | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Involves Datadog profiling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant