Skip to content

Conversation

@ericfirth
Copy link
Contributor

@ericfirth ericfirth commented Nov 7, 2025

This is one commit on top of the Waterdrop PR (here: #4874) to add DSM to the Waterdrop instrumentation

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions github-actions bot added core Involves Datadog core libraries integrations Involves tracing integrations tracing labels Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-11-07 19:59:20 UTC

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Typing analysis

Ignored files

This PR introduces 9 ignored files. It decreases the percentage of typed files from 36.87% to 36.49% (-0.38%).

Ignored files (+9-0)Introduced:
lib/datadog/tracing/contrib/karafka/framework.rb
lib/datadog/tracing/contrib/waterdrop.rb
lib/datadog/tracing/contrib/waterdrop/configuration/settings.rb
lib/datadog/tracing/contrib/waterdrop/distributed/propagation.rb
lib/datadog/tracing/contrib/waterdrop/ext.rb
lib/datadog/tracing/contrib/waterdrop/integration.rb
lib/datadog/tracing/contrib/waterdrop/middleware.rb
lib/datadog/tracing/contrib/waterdrop/patcher.rb
lib/datadog/tracing/contrib/waterdrop/producer.rb

@datadog-official
Copy link

datadog-official bot commented Nov 7, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 96.52%
Total Coverage: 98.54% (-0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dfadb4d | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2025

Benchmarks

Benchmark execution time: 2025-11-10 20:05:58

Comparing candidate commit dfadb4d in PR branch eric.firth/add-waterdrop-dsm-integration with baseline commit c560834 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - Allocations ()

  • 🟥 throughput [-211347.299op/s; -202981.572op/s] or [-6.412%; -6.158%]

@ericfirth ericfirth force-pushed the eric.firth/add-waterdrop-dsm-integration branch from cd833a4 to 6159509 Compare November 10, 2025 16:28
@ericfirth ericfirth force-pushed the eric.firth/add-waterdrop-dsm-integration branch from 15c6af6 to b2b06c0 Compare November 10, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants