refactor(sampling)!: use sampling from libdatadog [APMSP-3021]#154
Conversation
61d3be1 to
d7f48f3
Compare
6326df5 to
ed96d8c
Compare
d7f48f3 to
90e61b2
Compare
ed96d8c to
f6d60d3
Compare
90e61b2 to
2a70bfc
Compare
ekump
left a comment
There was a problem hiding this comment.
a couple of non-blocking comments. LGTM
f6d60d3 to
6a653dc
Compare
2a70bfc to
5003a05
Compare
4235c71 to
2e27e2a
Compare
5003a05 to
c443b13
Compare
2e27e2a to
8338fa2
Compare
c443b13 to
de4f688
Compare
4593286 to
f3f7041
Compare
71bd063 to
d5c0f6e
Compare
5c949ee to
9f857ea
Compare
9f857ea to
e27e124
Compare
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 0a4e479 | Docs | Datadog PR Page | Give us feedback! |
e27e124 to
263d58b
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
263d58b to
5504211
Compare
|
To prevent crates with unsupported msrv from slipping in, could we define in ? |
5504211 to
0a4e479
Compare
|
@iunanua I have no idea. If you know that |
Moves the sampling code into a separate crate, and uses the moved sampling code from
libdatadogDataDog/libdatadog#1927These are the benchmark numbers after DataDog/libdatadog#1977 landed.
OTel Sampling Benchmarks vs
mainAllocations
rule_all_spans_only_rateservice_rule_matchingservice_rule_not_matchingname_pattern_rule_matchingname_pattern_rule_not_matchingresource_pattern_rule_matchingresource_pattern_rule_not_matchingtag_rule_matchingtag_rule_not_matchingcomplex_rule_matchingcomplex_rule_partial_matchmultiple_rules_first_matchmultiple_rules_last_matchmany_attributesparent_sampled_short_circuitparent_not_sampled_short_circuitunicode_rule_matchingWall Time
rule_all_spans_only_rateservice_rule_matchingservice_rule_not_matchingname_pattern_rule_matchingname_pattern_rule_not_matchingresource_pattern_rule_matchingresource_pattern_rule_not_matchingtag_rule_matchingtag_rule_not_matchingcomplex_rule_matchingcomplex_rule_partial_matchmultiple_rules_first_matchmultiple_rules_last_matchmany_attributesparent_sampled_short_circuitparent_not_sampled_short_circuitunicode_rule_matching