refactor(rc): wire libdatadog Remote Config client#222
Draft
iunanua wants to merge 3 commits into
Draft
Conversation
…egistry Adapt to the updated `datadog-remote-config` public API: - Drop `ProductParser` and `std::any::Any` imports; add `RemoteConfigContent`. - Replace the manual `RemoteConfigParsedData` impl on `ApmTracingConfig` (with `as_any` + `product`) with a single `RemoteConfigContent` impl exposing `const PRODUCT` and `fn parse(&[u8]) -> anyhow::Result<Self>`. The `RemoteConfigParsedData` marker is now provided by a blanket impl upstream. - Remove `apm_tracing_parser()`; `build_fetcher` uses the typed builder `ParserRegistry::new().with::<ApmTracingConfig>()`. - Update `Updated` alias to `anyhow::Result<Option<Box<dyn RemoteConfigParsedData>>>` to match `RegistryParser::Parsed`. `None` is the new "no parser registered" signal that replaces the old `IgnoredProduct` sentinel; `apply_file` and `apply_remove` early-return on `None` with the same no-op semantics. - Update `test_apm_tracing_parser_round_trip` to call `ApmTracingConfig::parse` directly and assert on `ApmTracingConfig::PRODUCT`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Source every libdd-* crate (workspace-direct and transitive through datadog-remote-config) from a single libdatadog git ref, removing the libdd-common-rc renamed alias that previously bridged a v3/v4 split. Tracks libdatadog branch igor/rc/di-refactor-claude. Adds direct libdd-capabilities-impl dependency for NativeCapabilities and updates call sites for the new TraceExporter<H> API and async wait_agent_info_ready. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
iunanua
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datadog-remote-configfrom libdatadog, replacing the prior placeholder.ParserRegistry,RemoteConfigContenttrait (withconst PRODUCTandfn parse)Currently tracks libdatadog branch
igor/rc/di-refactor-claude. The[patch.crates-io]block is marked TODO and should be dropped once the matching libdatadog versions are published to crates.io.Notes
It is registering a custom parser for
ApmTracingConfigbut it could use the builtin RC parser forDynamicConfigFile. In that case we'll need to update config and sampler methods and types related withtrace_sampling_rules. I have decided not to change it after the sampler migration is in place.🤖 Generated with Claude Code