Skip to content

fix(ci): prevent shell expansion of publish tag#234

Merged
paullegranddc merged 1 commit into
mainfrom
codex/propose-fix-for-command-injection-vulnerability
May 22, 2026
Merged

fix(ci): prevent shell expansion of publish tag#234
paullegranddc merged 1 commit into
mainfrom
codex/propose-fix-for-command-injection-vulnerability

Conversation

@paullegranddc
Copy link
Copy Markdown
Collaborator

Motivation

  • Prevent command-injection via Git tag names in the publish workflow which could trigger shell command substitution and potentially exfiltrate the CRATES_IO_TOKEN secret.

Description

  • Update .github/workflows/publish.yaml to store steps.tag.outputs.tag in an environment variable PUBLISH_TAG and pass it to ./scripts/publish-crate.sh as "${PUBLISH_TAG}" instead of interpolating the GitHub expression directly in the run block.

Testing

  • No automated tests were run for this minimal workflow-only change; the edit is limited to .github/workflows/publish.yaml and does not change runtime release logic.

Codex Task

@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 Bot commented May 21, 2026

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bf19269 | Docs | Datadog PR Page | Give us feedback!

Signed-off-by: paullegranddc <paul.legranddescloizeaux@datadoghq.com>
@paullegranddc paullegranddc force-pushed the codex/propose-fix-for-command-injection-vulnerability branch from b1eca6a to bf19269 Compare May 21, 2026 21:44
@paullegranddc paullegranddc merged commit 91c551f into main May 22, 2026
34 checks passed
@paullegranddc paullegranddc deleted the codex/propose-fix-for-command-injection-vulnerability branch May 22, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants