fix(ci): prevent shell expansion of publish tag#234
Merged
paullegranddc merged 1 commit intoMay 22, 2026
Conversation
🎉 All green!🧪 All tests passed 🔗 Commit SHA: bf19269 | Docs | Datadog PR Page | Give us feedback! |
ekump
approved these changes
May 21, 2026
Signed-off-by: paullegranddc <paul.legranddescloizeaux@datadoghq.com>
b1eca6a to
bf19269
Compare
iunanua
approved these changes
May 22, 2026
bantonsson
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
publishworkflow which could trigger shell command substitution and potentially exfiltrate theCRATES_IO_TOKENsecret.Description
.github/workflows/publish.yamlto storesteps.tag.outputs.tagin an environment variablePUBLISH_TAGand pass it to./scripts/publish-crate.shas"${PUBLISH_TAG}"instead of interpolating the GitHub expression directly in therunblock.Testing
.github/workflows/publish.yamland does not change runtime release logic.Codex Task