Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGENTLESS] ECR documentation #27721

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[AGENTLESS] ECR documentation #27721

wants to merge 5 commits into from

Conversation

jinroh
Copy link

@jinroh jinroh commented Feb 20, 2025

What does this PR do? What is the motivation?

Update documentation to prepare for GA of ECR scanning via Agentless.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

@jinroh jinroh requested a review from a team as a code owner February 20, 2025 09:52
@jinroh jinroh changed the title Jinroh/agentless ecr [AGENTLESS] ECR documentation Feb 20, 2025
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback to comply with our style guide, but otherwise looks good. Thank you!

3. The scanner creates snapshots of volumes used in running VM instances. These snapshots serve as the basis for conducting scans. Using the snapshots, or the code, the scanner generates a list of packages.
4. After the scan is complete, the list of packages and information related to collected hosts are transmitted to Datadog, with all other data remaining within your infrastructure. Snapshots created during the scan cycle are deleted.
5. Leveraging the collected package list along with Datadog's access to the Trivy vulnerabilities database, Datadog finds matching affected vulnerabilities in your resources and code.
3. For Container Images from registries, the scanners will scan images from all running tasks, by pulling the layers from the registries using standard OCI APIs.
Copy link
Contributor

@rtrieu rtrieu Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. For Container Images from registries, the scanners will scan images from all running tasks, by pulling the layers from the registries using standard OCI APIs.
3. For Container Images from registries, the scanners scan images from all running tasks, by pulling the layers from the registries using standard OCI APIs.

- AWS ECR public
- AWS ECR private

**Note**: container image scanning from registry is only supported if you have installed agentless with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Note**: container image scanning from registry is only supported if you have installed agentless with:
**Note**: Container image scanning from registry is only supported if you have installed Agentless with:

@@ -20,7 +20,7 @@ Agentless Scanning provides visibility into vulnerabilities that exist within yo
Before setting up Agentless Scanning, ensure the following prerequisites are met:

- **Remote Configuration**: [Remote Configuration][3] is required to enable Datadog to send information to Agentless scanners, such as which cloud resources to scan.
- **Cloud permissions**: The Agentless Scanning instance requires specific permissions to scan hosts, containers, and functions. These permissions are automatically applied as part of the installation process.<br><br>
- **Cloud permissions**: The Agentless Scanning instance requires specific permissions to scan hosts, host images, container registries and functions. These permissions are automatically applied as part of the installation process.<br><br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Cloud permissions**: The Agentless Scanning instance requires specific permissions to scan hosts, host images, container registries and functions. These permissions are automatically applied as part of the installation process.<br><br>
- **Cloud permissions**: The Agentless Scanning instance requires specific permissions to scan hosts, host images, container registries, and functions. These permissions are automatically applied as part of the installation process.<br><br>

@@ -28,7 +28,7 @@ For existing users who want to add a new AWS account or enable Agentless Scannin
1. Select the AWS region where you want to create the CloudFormation stack.
1. Select an API key that is already configured for Remote Configuration. If the API key you select does not have Remote Configuration enabled, Remote Configuration is automatically enabled for that key upon selection.
1. **Send AWS Logs to Datadog** and **Detect security issues** are automatically selected by default. Leave the selections as-is.
1. The **Enable Vulnerability Management (Host, Container and Lambda)** switch is also enabled by default. Leave this selection as-is.
1. The **Enable Vulnerability Management (Host, Image Registries, Container and Lambda)** switch is also enabled by default. Leave this selection as-is.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. The **Enable Vulnerability Management (Host, Image Registries, Container and Lambda)** switch is also enabled by default. Leave this selection as-is.
1. The **Enable Vulnerability Management (Host, Image Registries, Container, and Lambda)** switch is also enabled by default. Leave this selection as-is.


4. The scanner creates snapshots of volumes used in running VM instances. These snapshots serve as the basis for conducting scans. Using the snapshots, or the code, the scanner generates a list of packages.
5. After the scan is complete, the list of packages and information related to collected hosts are transmitted to Datadog, with all other data remaining within your infrastructure. Snapshots created during the scan cycle are deleted.
6. Leveraging the collected package list along with Datadog's access to the Trivy vulnerabilities database, Datadog finds matching affected vulnerabilities in your resources and code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
6. Leveraging the collected package list along with Datadog's access to the Trivy vulnerabilities database, Datadog finds matching affected vulnerabilities in your resources and code.
6. Using the collected package list, along with Datadog's access to the Trivy vulnerabilities database, Datadog finds matching affected vulnerabilities in your resources and code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants