Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYNTH-18459] Add Synthetics Mobile IP ranges for HTTP steps #27726

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LuizGiserman
Copy link

@LuizGiserman LuizGiserman commented Feb 20, 2025

What does this PR do? What is the motivation?

This updates the list of IP ranges that Synthetics Mobile customers with restricted networks have to allow in order to use the new (still unreleased) HTTP steps feature.

Preview of the changes here

Merge instructions

Waiting for the Synthetics Mobile HTTP steps to be released (ETA week of February 24th)
Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@LuizGiserman LuizGiserman marked this pull request as ready for review February 20, 2025 13:32
@LuizGiserman LuizGiserman requested a review from a team as a code owner February 20, 2025 13:32
Copy link
Contributor

@@ -41,6 +41,19 @@ The following is the list of IP ranges associated with the real devices used for
`185.94.24.0/22`</br>
`34.96.70.78`</br>

The following is the list of IP ranges associated with Synthetics Mobile HTTP steps. Please disregard if your company does not use this feature.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe change "company..." to "tests do not use this feature"? A single company could have more than one Datadog org/more than one mobile app that they're testing etc.

@@ -41,6 +41,19 @@ The following is the list of IP ranges associated with the real devices used for
`185.94.24.0/22`</br>
`34.96.70.78`</br>

The following is the list of IP ranges associated with Synthetics Mobile HTTP steps. Please disregard if your company does not use this feature.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following is the list of IP ranges associated with Synthetics Mobile HTTP steps. Please disregard if your company does not use this feature.
Below is the list of IP ranges required for executing HTTP steps within Synthetic Mobile Application Tests. You may disregard these ranges if your tests do not use HTTP steps.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bit of CIDR notation may have been left off a couple of IPs

Copy link

@carolinekaufman carolinekaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from Synthetics Mobile!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants