Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update private_location.md #27738

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

thang62590
Copy link
Contributor

Add content about private locations being only supported on amd64 architecture

Add content about private locations being only supported on amd64 architecture
@thang62590 thang62590 requested a review from a team as a code owner February 20, 2025 23:19
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some minor updates per the style guide, and also to have the note render on a new line, as currently it's a bit confusing to have the note placed immediately after the asterisk. Screenshot for reference:
before_space

@@ -27,7 +27,7 @@ You can also use private locations to:
- **Verify the application performance in your internal testing environment** before you release new features to production with [Synthetic tests in your CI/CD pipelines][1].
- **Compare the application performance** from inside and outside your internal network.

Private locations are Docker containers or Windows services that you can install anywhere inside your private network. Retrieve the docker image on [Google Container Registry][2] or download the [Windows installer][13].**\***
Private locations are Docker containers or Windows services that you can install anywhere inside your private network. Retrieve the docker image on [Google Container Registry][2] or download the [Windows installer][13].**\*** **Note**: Currently, private locations on Docker containers are supported only on the amd64 architecture. If you have any questions about arm64 support, please contact [Datadog support][15].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Private locations are Docker containers or Windows services that you can install anywhere inside your private network. Retrieve the docker image on [Google Container Registry][2] or download the [Windows installer][13].**\*** **Note**: Currently, private locations on Docker containers are supported only on the amd64 architecture. If you have any questions about arm64 support, please contact [Datadog support][15].
Private locations are Docker containers or Windows services that you can install anywhere inside your private network. Retrieve the docker image on [Google Container Registry][2] or download the [Windows installer][13].**\***
**Note**: Private locations on Docker containers are supported only on the amd64 architecture. If you have any questions about arm64 support, contact [Datadog support][15].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants