-
Notifications
You must be signed in to change notification settings - Fork 1.2k
SLO burn rate indicator #32688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SLO burn rate indicator #32688
Conversation
Also updated SLO status pge to say SLO manage page instead
Preview links (active after the
|
cswatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! I mainly just have one comment + some suggested expanded alt text
|
|
||
| ### SLO burn rate indicator | ||
|
|
||
| Burn rate indicators identify SLOs that are consuming their error budget faster than their configured target permits within the rolling 2-hour evaluation window. They appear next to the applicable SLO names on the [SLO manage page][2]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Burn rate indicators identify SLOs that are consuming their error budget faster than their configured target permits within the rolling 2-hour evaluation window. They appear next to the applicable SLO names on the [SLO manage page][2]. | |
| Burn rate indicators identify SLOs that are consuming their error budget faster than their configured target permits within the rolling 2-hour evaluation window. Burn rate indicators appear next to the applicable SLO names on the [SLO manage page][2]. |
- Question on first sentence, because I see two different ways to interpret it:
- Burn rate indicators use a rolling 2-hour evaluation window to evaluate which SLOs are having too many errors too quickly
- SLOs permit a certain number of errors within a rolling 2-hour evaluation window, and burn rate indicators identify the ones that are having too many errors too quickly
tldr it's ambiguous what the within the rolling 2-hour evaluation window clause is referring to. I believe it should be the first interpretation, in which case maybe reword to Burn rate indicators identify (within a rolling 2-hour evaluation window) SLOs that are consuming their error budget faster than their configured target permits.? Inelegant suggestion here, I'll leave the rewording up to you.
|
|
||
| Burn rate indicators identify SLOs that are consuming their error budget faster than their configured target permits within the rolling 2-hour evaluation window. They appear next to the applicable SLO names on the [SLO manage page][2]. | ||
|
|
||
| {{< img src="/service_management/service_level_objectives/slo_burn_rate_indicator.png" alt="SLO burn rate indicator example" style="width:80%;" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {{< img src="/service_management/service_level_objectives/slo_burn_rate_indicator.png" alt="SLO burn rate indicator example" style="width:80%;" >}} | |
| {{< img src="/service_management/service_level_objectives/slo_burn_rate_indicator.png" alt="The SLO manage page in Datadog. A red icon appears next to the name of an SLO in the list. Mousing over the red icon displays a modal with further information, a burn rate visualization, and a link to the SLO's corresponding service page." style="width:80%;" >}} |
What does this PR do? What is the motivation?
Merge instructions
Merge readiness: