-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update & reorganize CloudSec disabling docs #33159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
daniel-pahor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This is really great. A couple of comments.
And one more thing, I see "Azure Subscription" is still mentioned three times in this doc and "Google Cloud Project" once - my bad I didn't mention we wanted it changed throughout the doc not just the de-activation part. Can we rename them to "account" too?
content/en/security/cloud_security_management/setup/agentless_scanning/enable.md
Outdated
Show resolved
Hide resolved
content/en/security/cloud_security_management/setup/agentless_scanning/enable.md
Show resolved
Hide resolved
Co-authored-by: Daniel Pahor <[email protected]>
…g/documentation into janine.chan/cloudsec-deactivation
|
Thank you, @daniel-pahor! Great catch with the remaining outdated terminology; I've just pushed a change to update that. If Slack says I'm OOO the next time you're able to take a look:
If you need anything else, #documentation is the place to go, and I'll be back on Wednesday too 🙂 Thank you for being so helpful and thorough with this task; you've really been an ideal collaborator! |
|
Thanks @janine-c enjoy your break. I fixed some nits then followed your instructions above. Thank you. |
| 1. Expand the Tenant containing the subscription where you want to deploy the Agentless scanner. | ||
| 1. Click the **Enable** button for the Azure subscription where you want to deploy the Agentless scanner. | ||
| 1. Click the **Enable** button for the Azure account where you want to deploy the Agentless scanner. | ||
| 1. Toggle **Vulnerability Scanning** to the on position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 1. Toggle **Vulnerability Scanning** to the on position. | |
| 1. Toggle **Vulnerability Scanning** to the on position. |
non-blocking, but in this case would emphasizing the "ON" in "on position" be helpful? I guess there's no "ON" and "OFF" as words in the UI, so maybe a different way than capitalizing?
What does this PR do? What is the motivation?
Merge instructions
Please wait to merge until we have the okay from @daniel-pahor and team. Thank you for sharing your expertise with us, Daniel!
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes