Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PG17 support #19625

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

PG17 support #19625

wants to merge 3 commits into from

Conversation

natashadada
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (e75c85f) to head (713a126).
Report is 5 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
postgres 93.37% <100.00%> (?)
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

natashadada
natashadada commented Feb 14, 2025
View reviewed changes
postgres/datadog_checks/postgres/statements.py
@@ -350,6 +357,7 @@ def _load_pg_stat_statements(self):

if self._check.pg_settings.get("track_io_timing") != "on":
desired_columns -= PG_STAT_STATEMENTS_TIMING_COLUMNS
desired_columns -= PG_STAT_STATEMENTS_TIMING_COLUMNS_LT_17
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to do a version check here

@gmastakar gmastakar mentioned this pull request Feb 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
agent/review-requested ecosystems/review-requested integration/postgres product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@natashadada