Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes dependency and move to correct place #19655

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

sarah-witt
Copy link
Contributor

What does this PR do?

Makes kubernetes an official dependency of kubevirt_api and updates version

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (3d8b6d5) to head (587e2b5).
Report is 14 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
kubevirt_api 82.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarah-witt sarah-witt marked this pull request as ready for review February 19, 2025 17:43
@sarah-witt sarah-witt requested a review from a team as a code owner February 19, 2025 17:43
@sarah-witt sarah-witt added this pull request to the merge queue Feb 21, 2025
Merged via the queue into master with commit 76a1a85 Feb 21, 2025
40 checks passed
@sarah-witt sarah-witt deleted the sarah/fix-kubevirt-dep branch February 21, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants