Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag FoundationDB process metrics with process class, assigned roles #19682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jon-signal
Copy link

What does this PR do?

This pull request adds additional tags to existing FoundationDB process metrics to help operators identify which roles the associated processes are performing.

Motivation

FoundationDB processes can take on one or more roles within a cluster. When scaling a cluster, operators generally add new processes for overloaded roles. The heuristics for "overloaded" vary by process, but basic indicators like CPU utilization often give helpful first-order clues for where to begin.

Before this change, each process would report metrics (like CPU utilization) such that each metric was tagged with the process ID. We can use the process ID in conjunction with additional external tools to identify the roles a process is performing, but it would be much more convenient if the process metrics were already tagged by role. After this change, process metrics will be tagged with all of the roles performed by the associated process.

This change should not affect any existing queries, but will allow operators to write new queries to show things like "average CPU load for GRV proxies" or "network throughput for log processes."

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@jon-signal jon-signal force-pushed the foundationdb_process_role_tags branch from 8f51d9f to 93c6dda Compare February 21, 2025 18:19
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (b732c62) to head (93c6dda).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
foundationdb 83.48% <62.50%> (-0.36%) ⬇️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant