Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMCON-748] fix DD exporter and connector metrics on OTel collector dashboard #19758

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Mar 4, 2025

What does this PR do?

Fix DD exporter and connector APM related metrics on OTel collector dashboard

Motivation

  • https://datadoghq.atlassian.net/browse/SEMCON-748 Filter internal APM health metrics (otelcol_datadog_trace_agent_* metrics) by source:datadogexporter, only metrics with this tag are indeed from DD exporter or connector.
    • Note most metrics from DD connector also have source:datadogexporter rather than source:datadogconnector because metrics are sent with DD exporter.
  • https://datadoghq.atlassian.net/browse/OTAGENT-44 Add deprecation notice to traces/s and spans/s metrics on the DD connector section. Those 2 metrics no longer apply when native ingest in DD connector is enabled, in that case traces go through the new OTel stats API rather than the OTLP receiver in trace agent.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

steveny91
steveny91 previously approved these changes Mar 4, 2025
mx-psi
mx-psi previously approved these changes Mar 5, 2025
@songy23 songy23 removed the request for review from IbraheemA March 5, 2025 14:04
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed stale reviews from steveny91 and mx-psi March 5, 2025 14:06

Review from steveny91 is dismissed.
Related teams and files:

  • agent-integrations
    • otel/assets/dashboards/otel_collector_metrics_dashboard.json
      Review from mx-psi is dismissed.
      Related teams and files:
  • opentelemetry
    • otel/assets/dashboards/otel_collector_metrics_dashboard.json
@songy23 songy23 enabled auto-merge March 5, 2025 14:07
@songy23 songy23 requested review from mx-psi and steveny91 March 5, 2025 14:07
@songy23
Copy link
Member Author

songy23 commented Mar 5, 2025

Fixed a typo, could you take another look? @steveny91 @mx-psi

Merged via the queue into master with commit 80d33e4 Mar 5, 2025
45 of 46 checks passed
@songy23 songy23 deleted the yang.song/SEMCON-748 branch March 5, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants