Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix citrix_hypervisor failing tests #19936

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NouemanKHAL
Copy link
Member

@NouemanKHAL NouemanKHAL commented Mar 26, 2025

What does this PR do?

  • Fixes the tests fixtures to be well-formed jsons.
  • Removes the usage of yaml package to parse the response in favor of the response.json() method.

More info here: https://docs.xenserver.com/en-us/xenserver/developer/sdk-guide/using-http.html

Motivation

Fix failing test in the minimum_base_check job

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@NouemanKHAL NouemanKHAL requested a review from a team as a code owner March 26, 2025 10:09
@NouemanKHAL NouemanKHAL changed the title Fix citrix-hypervisor failing tests Fix citrix_hypervisor failing tests Mar 26, 2025
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.98%. Comparing base (0965ff0) to head (92adca3).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
citrix_hypervisor 86.75% <100.00%> (-0.71%) ⬇️
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# See https://github.com/yaml/pyyaml/issues/443
data = yaml.load(r.content, Loader=yaml.SafeLoader)

data = r.json()
Copy link
Contributor

@AAraKKe AAraKKe Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering, why is it that we were not doing this before and now we can? I mean, we were loading it with yaml before for some reason right? Just making sure this is not going to fix tests but fail when running the integration with the real system. If we are covered by any integration/e2e I am ok with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants