Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ: Adding the queue_delivery_metrics OpenMetrics endpoint #19963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edgrz
Copy link

@edgrz edgrz commented Mar 31, 2025

What does this PR do?

As part of /detailed metric endpoints, there's a queue delivery metrics one (docs), that were not integrated yet into datadog agent. This PR integrates them.

Motivation

I prepared the DD agent to scrape such /detailed?family=queue_delivery_metrics but none of them were appearing in DD. So, looking into the source code I realize there was yet no mapping for there.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (60b6a09) to head (52037e4).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
rabbitmq 95.59% <ø> (ø)
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@edgrz edgrz changed the title RabbitMQ: Adding the queue_delivery_metrics RabbitMQ: Adding the queue_delivery_metrics OpenMetrics endpoint Mar 31, 2025
@dkirov-dd dkirov-dd assigned iliakur and dkirov-dd and unassigned iliakur Apr 4, 2025
@dkirov-dd
Copy link
Contributor

Hello @edgrz, thank you for your contribution!
Could you add these metrics to the metadata.csv?

It seems like they were added in this commit: rabbitmq/rabbitmq-server@bb93e71
Out of curiosity, which version of RabbitMQ are you using? Are you sure it exposes them?

Lastly, it would be great to include the new metrics in the tests as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants