Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to lowercase "device" tag #19964

Merged
merged 6 commits into from
Apr 1, 2025

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Mar 31, 2025

What does this PR do?

Motivation

On some linux systems the device tag comes in upper case. Our backend keeps the uppercase and adds a lowercase equivalent. Some customers can't use this and also can't rely on device_name. For these customers we add this option.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (01712de) to head (6e7ed1a).
Report is 10 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
disk 87.72% <90.90%> (+2.12%) ⬆️
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

NouemanKHAL
NouemanKHAL previously approved these changes Mar 31, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed NouemanKHAL’s stale review April 1, 2025 08:02

Review from NouemanKHAL is dismissed.
Related teams and files:

  • agent-integrations
    • disk/tests/test_unit.py
@iliakur iliakur added this pull request to the merge queue Apr 1, 2025
Merged via the queue into master with commit 22f0280 Apr 1, 2025
39 checks passed
@iliakur iliakur deleted the ik/AGENT-13271/disk-lowercase-device-tag branch April 1, 2025 14:33
github-actions bot pushed a commit to jon-signal/integrations-core that referenced this pull request Apr 1, 2025
* Add option to lowercase "device" tag

* add changelog

* Limit to linux

* Update disk/assets/configuration/spec.yaml

Co-authored-by: NouemanKHAL <[email protected]>

* sync config

* fix style

---------

Co-authored-by: NouemanKHAL <[email protected]> 22f0280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants