-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to lowercase "device" tag #19964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
NouemanKHAL
reviewed
Mar 31, 2025
Co-authored-by: NouemanKHAL <[email protected]>
NouemanKHAL
previously approved these changes
Mar 31, 2025
Review from NouemanKHAL is dismissed.
Related teams and files:
- agent-integrations
- disk/tests/test_unit.py
steveny91
approved these changes
Apr 1, 2025
Kyle-Neale
approved these changes
Apr 1, 2025
github-actions bot
pushed a commit
to jon-signal/integrations-core
that referenced
this pull request
Apr 1, 2025
* Add option to lowercase "device" tag * add changelog * Limit to linux * Update disk/assets/configuration/spec.yaml Co-authored-by: NouemanKHAL <[email protected]> * sync config * fix style --------- Co-authored-by: NouemanKHAL <[email protected]> 22f0280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
On some linux systems the
device
tag comes in upper case. Our backend keeps the uppercase and adds a lowercase equivalent. Some customers can't use this and also can't rely ondevice_name
. For these customers we add this option.Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged