Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tag signing to be able to run ddev tests locally #19971

Merged
merged 3 commits into from
Apr 9, 2025

Conversation

AAraKKe
Copy link
Contributor

@AAraKKe AAraKKe commented Apr 1, 2025

What does this PR do?

This is a small PR modifying the git commands run on the release agent unit tests in ddev.

Motivation

Locally, after setting up git signing, all tags run are annotated because tags are configured to be signed. This makes every git tag command run for these unit tests fail. By asking the tags not to be signed we can run these tests locally.

This should have no impact in CI because in CI tags are not signed.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.81%. Comparing base (f8afb3a) to head (b361fed).
Report is 71 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory ?
activemq_xml ?
airflow ?
amazon_msk ?
ambari ?
apache ?
appgate_sdp ?
arangodb ?
argo_rollouts ?
argo_workflows ?
argocd ?
aspdotnet ?
avi_vantage ?
aws_neuron ?
azure_iot_edge ?
boundary ?
btrfs ?
cacti ?
calico ?
cassandra_nodetool ?
ceph ?
cert_manager ?
cisco_aci ?
citrix_hypervisor ?
clickhouse ?
cloud_foundry_api ?
cloudera ?
cockroachdb ?
consul ?
coredns ?
couch ?
crio ?
datadog_checks_base ?
datadog_checks_dev ?
datadog_checks_downloader ?
datadog_cluster_agent ?
dcgm ?
ddev 87.78% <100.00%> (+0.60%) ⬆️
directory ?
disk ?
dns_check ?
druid ?
duckdb ?
ecs_fargate ?
eks_fargate ?
envoy ?
esxi ?
etcd ?
external_dns ?
fluentd ?
fluxcd ?
fly_io ?
foundationdb ?
gearmand ?
gitlab_runner ?
glusterfs ?
go_expvar ?
gunicorn ?
haproxy ?
harbor ?
hazelcast ?
hdfs_datanode ?
hdfs_namenode ?
http_check ?
ibm_ace ?
ibm_db2 ?
ibm_i ?
ibm_mq ?
ibm_was ?
impala ?
infiniband ?
istio ?
karpenter ?
keda ?
kong ?
kube_apiserver_metrics ?
kube_controller_manager ?
kube_dns ?
kube_metrics_server ?
kube_proxy ?
kube_scheduler ?
kubeflow ?
kubelet ?
kubernetes_cluster_autoscaler ?
kubernetes_state ?
kubevirt_api ?
kubevirt_controller ?
kubevirt_handler ?
kyototycoon ?
kyverno ?
lighttpd ?
linkerd ?
linux_proc_extras ?
mapr ?
mapreduce ?
marathon ?
mcache ?
mesos_master ?
mesos_slave ?
milvus ?
nagios ?
network ?
nfsstat ?
nginx ?
nginx_ingress_controller ?
nvidia_nim ?
nvidia_triton ?
octopus_deploy ?
openldap ?
openmetrics ?
openstack ?
pgbouncer ?
php_fpm ?
postfix ?
powerdns_recursor ?
process ?
prometheus ?
proxysql ?
pulsar ?
quarkus ?
rabbitmq ?
ray ?
redisdb ?
rethinkdb ?
riak ?
riakcs ?
scylla ?
silk ?
silverstripe_cms ?
singlestore ?
slurm ?
snowflake ?
sonarqube ?
sonatype_nexus ?
spark ?
squid ?
ssh_check ?
statsd ?
strimzi ?
supabase ?
supervisord ?
system_core ?
system_swap ?
tcp_check ?
teamcity ?
tekton ?
teleport ?
temporal ?
teradata ?
tibco_ems ?
tls ?
torchserve ?
traefik_mesh ?
traffic_server ?
twemproxy ?
twistlock ?
varnish ?
vault ?
velero ?
vllm ?
vsphere ?
weaviate ?
win32_event_log ?
wmi_check ?
yarn ?
zk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AAraKKe AAraKKe added this pull request to the merge queue Apr 9, 2025
Merged via the queue into master with commit ba432bd Apr 9, 2025
35 checks passed
@AAraKKe AAraKKe deleted the aarakke/fix-local-test-agent-release branch April 9, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants