Skip to content

DDS: Linux Audit Logs Updates#20345

Open
tirthrajchaudhari-crest wants to merge 9 commits intoDataDog:masterfrom
bhargavnariyanicrest:linux-audit-logs-update
Open

DDS: Linux Audit Logs Updates#20345
tirthrajchaudhari-crest wants to merge 9 commits intoDataDog:masterfrom
bhargavnariyanicrest:linux-audit-logs-update

Conversation

@tirthrajchaudhari-crest
Copy link
Copy Markdown
Contributor

@tirthrajchaudhari-crest tirthrajchaudhari-crest commented May 21, 2025

What does this PR do?

  • Added support for SYSCALL logs
  • Updated the pipeline
  • Added system calls dashboard
  • Update README to include setup steps for audit rules

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
Copy Markdown
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for contributing to our docs! i've left some feedback mainly to comply with our style guide.

Comment thread linux_audit_logs/README.md Outdated

### Setup Audit Rules (Optional)

1. Create/Edit the Audit Rules File
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Create/Edit the Audit Rules File
1. Create or edit the Audit Rules file:

Comment thread linux_audit_logs/README.md Outdated
sudo systemctl restart auditd
```

### Setup Audit Rules (Optional)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Setup Audit Rules (Optional)
### Set up Audit Rules (optional)

Comment thread linux_audit_logs/README.md Outdated
sudo nano /etc/audit/rules.d/audit.rules
```

2. Configure the audit rules based on your requirements. For reference, check out [audit rulesets][9].
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Configure the audit rules based on your requirements. For reference, check out [audit rulesets][9].
2. Configure the audit rules based on your requirements. For reference, see [audit rulesets][9].

Comment thread linux_audit_logs/README.md Outdated

2. Configure the audit rules based on your requirements. For reference, check out [audit rulesets][9].

3. Reload Audit Rules
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Reload Audit Rules
3. Reload Audit Rules:

Comment thread linux_audit_logs/README.md Outdated
sudo augenrules --load
```

4. Verify Loaded Rules
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Verify Loaded Rules
4. Verify loaded rules:

buraizu
buraizu previously approved these changes May 21, 2025
Copy link
Copy Markdown
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one minor update requested for screen-reader accessibility, as well as some additional suggestions for consistency with casing and punctuation.

Comment thread linux_audit_logs/README.md Outdated

### Setup Audit Rules (Optional)

1. Create/Edit the Audit Rules File
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Create/Edit the Audit Rules File
1. Create or Edit the audit rules file.

Comment thread linux_audit_logs/README.md Outdated

2. Configure the audit rules based on your requirements. For reference, check out [audit rulesets][9].

3. Reload Audit Rules
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Reload Audit Rules
3. Reload audit rules.

Comment thread linux_audit_logs/README.md Outdated
sudo augenrules --load
```

4. Verify Loaded Rules
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Verify Loaded Rules
4. Verify loaded rules.


3. Reload Audit Rules
```shell
sudo augenrules --load
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm that augenrules is the correct spelling.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's the correct spelling.

@temporal-github-worker-1 temporal-github-worker-1 Bot dismissed buraizu’s stale review May 22, 2025 05:32

Review from buraizu is dismissed. Related teams and files:

  • documentation
    • linux_audit_logs/README.md
@tirthrajchaudhari-crest
Copy link
Copy Markdown
Contributor Author

Hey @rtrieu @buraizu, Both changes look good, but for now, we are proceeding with using a colon after the setup step statements.

buraizu
buraizu previously approved these changes May 22, 2025
rtrieu
rtrieu previously approved these changes May 28, 2025
@temporal-github-worker-1 temporal-github-worker-1 Bot dismissed stale reviews from buraizu and rtrieu September 19, 2025 08:35

Review from buraizu is dismissed. Related teams and files:

  • documentation
    • linux_audit_logs/manifest.json

Review from rtrieu is dismissed. Related teams and files:

  • documentation
    • linux_audit_logs/manifest.json
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 19, 2025

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

- name: Lookup on `success` to `result` Field
enabled: true
source: success
target: result
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field doesn't seem to be used for the status remapper later on (here) which means you are not using it for the status of the log.

Is that expected?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have made a minor update in the log pipeline so that this field will be used to map the status for the log.

Copy link
Copy Markdown
Contributor

@brunorenier brunorenier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for logs-core

Comment thread linux_audit_logs/README.md
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a dark mode screenshot for the dashboard?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a update PR for this integration and we usually add only ligh themed dashboard screenshots in tile.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tirthrajchaudhari-crest, we’ve recently updated our guidelines for integration tiles - screenshots should now include a dark mode view and show a high volume of logs to better represent real-world usage. Could you please update the existing screenshots accordingly?

Also, could you ensure that the aspect ratio looks correct (for example, circles shouldn’t appear distorted)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nubtron We have updated the dashboard images which now includes light and dark version of images with high volume of logs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants