Skip to content

[DBMON-5405] Update Mysql integration to use TagManager #20417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 2, 2025

Conversation

eric-weaver
Copy link
Contributor

What does this PR do?

Updates the mysql integration check to make use of TagManager class rather than keeping track of multiple tag lists.

Notable changes

  • Removes the concept of two sets of tag lists where we were keeping a second list that excluded dd.internal.resource tags only from submission of database_instance metadata events. This is no longer needed as the backend now filters these out itself so this simplifies the integration.
  • Adds dbms_flavor tag to database_instance metadata events. This fixes a bug where this tag would be missing on any metric or event that relied on Unified Tagging linking
  • Overall it simplifies our ability to add / update and replace tags as the values they are derived from change which will help lead to more accurate tags on metrics and events

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (095c770) to head (e6c4691).
Report is 7 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
mysql 89.30% <97.56%> (+0.15%) ⬆️
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-weaver eric-weaver added this pull request to the merge queue Jun 2, 2025
Merged via the queue into master with commit d94e1ec Jun 2, 2025
22 checks passed
@eric-weaver eric-weaver deleted the eric.weaver/DBMON-5405 branch June 2, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants