Skip to content

Remove line number map #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zhengyu123 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Remove line number map #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ddprof-lib/src/main/cpp/flightRecorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ void Lookup::fillJavaMethodInfo(MethodInfo *mi, jmethodID method,
}
jvmtiEnv *jvmti = VM::jvmti();


jvmtiPhase phase;
jclass method_class = NULL;
// invariant: these strings must remain null, or be assigned by JVMTI
Expand Down Expand Up @@ -150,11 +151,12 @@ void Lookup::fillJavaMethodInfo(MethodInfo *mi, jmethodID method,
((!VM::isOpenJ9() || method_class != reinterpret_cast<jclass>(-1)) && jvmti->GetClassSignature(method_class, &class_name, NULL) == 0) &&
jvmti->GetMethodName(method, &method_name, &method_sig, NULL) == 0) {

/*
if (first_time) {
jvmti->GetLineNumberTable(method, &line_number_table_size,
&line_number_table);
}

*/
// Check if the frame is Thread.run or inherits from it
if (strncmp(method_name, "run", 4) == 0 &&
strncmp(method_sig, "()V", 3) == 0) {
Expand Down Expand Up @@ -247,11 +249,12 @@ void Lookup::fillJavaMethodInfo(MethodInfo *mi, jmethodID method,
mi->_sig = method_sig_id;
mi->_type = FRAME_INTERPRETED;
mi->_is_entry = entry;
/*
if (line_number_table != nullptr) {
mi->_line_number_table = std::make_shared<SharedLineNumberTable>(
line_number_table_size, line_number_table);
}

*/
// strings are null or came from JVMTI
if (method_name) {
jvmti->Deallocate((unsigned char *)method_name);
Expand Down
Loading