Skip to content

Fix memory leak in LibraryPatcher::initialize() #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 6 commits into from
Closed

Fix memory leak in LibraryPatcher::initialize() #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
843ee69
Initial plan
Copilot Jan 21, 2026
fcee7d1
Fix memory leak in LibraryPatcher::initialize()
Copilot Jan 21, 2026
f5a7c0c
Remove build log from git
Copilot Jan 21, 2026
a62688b
Add null check for realpath() return value
Copilot Jan 21, 2026
f6caff4
Complete memory leak fix
Copilot Jan 21, 2026
990c5dd
Remove CodeQL symlink
Copilot Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ datadog/maven/resources
.history
.claude/settings.local.json
/jmh-*
build_output.log
7 changes: 6 additions & 1 deletion ddprof-lib/src/main/cpp/libraryPatcher_linux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,19 @@ SpinLock LibraryPatcher::_lock;
const char* LibraryPatcher::_profiler_name = nullptr;
PatchEntry LibraryPatcher::_patched_entries[MAX_NATIVE_LIBS];
int LibraryPatcher::_size = 0;
static char _profiler_path[PATH_MAX];

void LibraryPatcher::initialize() {
if (_profiler_name == nullptr) {
Dl_info info;
void* caller_address = __builtin_return_address(0); // Get return address of caller
bool ret = dladdr(caller_address, &info);
assert(ret);
_profiler_name = realpath(info.dli_fname, nullptr);
_profiler_name = realpath(info.dli_fname, _profiler_path);
if (_profiler_name == nullptr) {
// realpath() failed, fall back to original path
_profiler_name = info.dli_fname;
}
_size = 0;
}
}
Expand Down