-
Notifications
You must be signed in to change notification settings - Fork 21
feat(data-pipeline): add runtime-independent agentless sending #2389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rochdev
wants to merge
7
commits into
main
Choose a base branch
from
rochdev/host-managed-data-pipeline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+564
−202
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5d46697
feat(data-pipeline): add runtime-independent request preparation
rochdev c3467e2
fix(data-pipeline): preserve wasm no-default build
rochdev 52dfcbb
fix(common): enable http client for reqwest
rochdev 322d933
fix(data-pipeline): harden host-managed transport
rochdev 3665218
fix(trace-utils): restore feature-only HTTP support
rochdev cbe142c
refactor(data-pipeline): keep agentless send lifecycle in rust
rochdev b442108
refactor(data-pipeline): preserve existing module layout
rochdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| [package] | ||
| name = "libdd-data-pipeline-core" | ||
| version = "1.0.0" | ||
| description = "Runtime-independent operations for Datadog APM data pipelines." | ||
| homepage = "https://github.com/DataDog/libdatadog/tree/main/libdd-data-pipeline-core" | ||
| repository = "https://github.com/DataDog/libdatadog/tree/main/libdd-data-pipeline-core" | ||
| rust-version.workspace = true | ||
| edition.workspace = true | ||
| license.workspace = true | ||
|
|
||
| [dependencies] | ||
| http = "1" | ||
| serde_json.workspace = true | ||
| thiserror = "1.0" | ||
| libdd-capabilities = { version = "3.0.0", path = "../libdd-capabilities" } | ||
| libdd-common = { version = "5.2.0", path = "../libdd-common", default-features = false } | ||
| libdd-trace-utils = { version = "10.1.0", path = "../libdd-trace-utils", default-features = false } | ||
|
|
||
| [dev-dependencies] | ||
| bytes = "1.11.1" | ||
| futures = { workspace = true, features = ["executor"] } | ||
| libdd-tinybytes = { version = "1.1.2", path = "../libdd-tinybytes", features = ["bytes_string"] } | ||
| zstd = { version = "0.13", default-features = false } | ||
|
|
||
| [features] | ||
| default = [] | ||
| compression = ["libdd-trace-utils/compression"] | ||
| regex-lite = ["libdd-common/regex-lite"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Copyright 2024-Present Datadog, Inc. https://www.datadoghq.com/ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| //! Agentless APM trace export configuration. | ||
|
|
||
| use std::{fmt::Debug, time::Duration}; | ||
|
|
||
| pub const DEFAULT_AGENTLESS_TIMEOUT: Duration = Duration::from_secs(15); | ||
|
|
||
| /// Agentless trace exporter configuration. | ||
| #[derive(Clone)] | ||
| pub struct AgentlessTraceConfig { | ||
| /// Full URL to POST traces to (e.g. | ||
| /// `https://public-trace-http-intake.logs.datadoghq.com/v1/input`). | ||
| pub endpoint_url: String, | ||
| /// Datadog API key used for the `dd-api-key` header. | ||
| pub api_key: String, | ||
| /// Request timeout. | ||
| pub timeout: Duration, | ||
| } | ||
|
|
||
| impl Debug for AgentlessTraceConfig { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| f.debug_struct("AgentlessTraceConfig") | ||
| .field("endpoint_url", &self.endpoint_url) | ||
| .field("api_key", &"<redacted>") | ||
| .field("timeout", &self.timeout) | ||
| .finish() | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these marked as optional. The are already not added for wasm and the codepaths providing the http client are already gated as to compile the crate.
So I don't see how refactoring libdd-common in necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WASM is only half the equation. Without making them explicitly optional, NAPI-RS was still including them. While some things are build target specific, some other things are not and need to be controllable regardless of the target.