Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix crash stack trackes on musl #870

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] Fix crash stack trackes on musl #870

wants to merge 5 commits into from

Conversation

r1viollet
Copy link
Contributor

What does this PR do?

Check out the new RFC to get a good description.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-02-17 16:33:10

Comparing candidate commit 16fe287 in PR branch r1viollet/unwind_rfc with baseline commit a8fb144 in branch main.

Found 7 performance improvements and 41 performance regressions! Performance is the same for 4 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟥 execution_time [+4.187ms; +4.262ms] or [+7.799%; +7.939%]

scenario:benching string interning on wordpress profile

  • 🟩 execution_time [-6.347µs; -6.144µs] or [-4.179%; -4.046%]

scenario:concentrator/add_spans_to_concentrator

  • 🟥 execution_time [+321.484µs; +324.063µs] or [+5.416%; +5.459%]

scenario:credit_card/is_card_number/

  • 🟥 execution_time [+371.275ns; +372.934ns] or [+9.488%; +9.531%]
  • 🟥 throughput [-22238422.479op/s; -22145653.548op/s] or [-8.702%; -8.665%]

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟥 execution_time [+15.053µs; +15.427µs] or [+18.082%; +18.531%]
  • 🟥 throughput [-1879963.554op/s; -1836858.698op/s] or [-15.649%; -15.290%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+13.284µs; +13.503µs] or [+16.703%; +16.979%]
  • 🟥 throughput [-1826506.345op/s; -1798025.663op/s] or [-14.526%; -14.299%]

scenario:credit_card/is_card_number/37828224631

  • 🟥 execution_time [+371.764ns; +373.270ns] or [+9.501%; +9.540%]
  • 🟥 throughput [-22259081.913op/s; -22173583.689op/s] or [-8.710%; -8.676%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+7.353µs; +7.484µs] or [+9.622%; +9.793%]
  • 🟥 throughput [-1168571.734op/s; -1147452.685op/s] or [-8.930%; -8.769%]

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟥 execution_time [+7.622µs; +7.634µs] or [+14.819%; +14.843%]
  • 🟥 throughput [-2513347.363op/s; -2509343.659op/s] or [-12.926%; -12.905%]

scenario:credit_card/is_card_number/x371413321323331

  • 🟥 execution_time [+803.529ns; +804.743ns] or [+13.309%; +13.329%]
  • 🟥 throughput [-19480751.795op/s; -19452263.910op/s] or [-11.762%; -11.745%]

scenario:credit_card/is_card_number_no_luhn/

  • 🟥 execution_time [+371.477ns; +372.437ns] or [+9.494%; +9.518%]
  • 🟥 throughput [-22213473.591op/s; -22155121.053op/s] or [-8.692%; -8.669%]

scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005

  • 🟥 execution_time [+9.988µs; +10.063µs] or [+15.080%; +15.192%]
  • 🟥 throughput [-1991969.846op/s; -1977490.484op/s] or [-13.194%; -13.098%]

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

  • 🟥 execution_time [+6.560µs; +6.604µs] or [+10.990%; +11.064%]
  • 🟥 throughput [-1669205.135op/s; -1658400.418op/s] or [-9.964%; -9.899%]

scenario:credit_card/is_card_number_no_luhn/37828224631

  • 🟥 execution_time [+371.288ns; +372.157ns] or [+9.488%; +9.510%]
  • 🟥 throughput [-22193169.316op/s; -22139566.243op/s] or [-8.685%; -8.664%]

scenario:credit_card/is_card_number_no_luhn/378282246310005

  • 🟥 execution_time [+6.135µs; +6.200µs] or [+10.788%; +10.903%]
  • 🟥 throughput [-1729749.401op/s; -1711609.999op/s] or [-9.836%; -9.733%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟥 execution_time [+7.629µs; +7.642µs] or [+14.836%; +14.859%]
  • 🟥 throughput [-2515860.544op/s; -2511853.951op/s] or [-12.938%; -12.918%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟥 execution_time [+802.213ns; +804.143ns] or [+13.285%; +13.317%]
  • 🟥 throughput [-19466392.602op/s; -19417801.864op/s] or [-11.754%; -11.725%]

scenario:ip_address/quantize_peer_ip_address_benchmark

  • 🟥 execution_time [+430.909ns; +444.398ns] or [+8.503%; +8.770%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟥 execution_time [+2.670µs; +2.710µs] or [+14.560%; +14.778%]
  • 🟥 throughput [-7021131.365op/s; -6926961.848op/s] or [-12.876%; -12.703%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟥 execution_time [+2.666µs; +2.689µs] or [+24.799%; +25.015%]
  • 🟥 throughput [-18616957.782op/s; -18479608.597op/s] or [-20.012%; -19.864%]

scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...

  • 🟩 execution_time [-76.205µs; -75.835µs] or [-15.069%; -14.996%]
  • 🟩 throughput [+348899.862op/s; +350806.297op/s] or [+17.644%; +17.741%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟩 execution_time [-14.331µs; -14.113µs] or [-8.108%; -7.985%]
  • 🟩 throughput [+491458.269op/s; +498552.944op/s] or [+8.686%; +8.812%]

scenario:normalization/normalize_service/normalize_service/[empty string]

  • 🟥 execution_time [+8.101µs; +8.132µs] or [+21.514%; +21.598%]
  • 🟥 throughput [-4719108.437op/s; -4700472.994op/s] or [-17.769%; -17.699%]

scenario:normalization/normalize_service/normalize_service/test_ASCII

  • 🟩 execution_time [-5.154µs; -5.118µs] or [-10.670%; -10.595%]
  • 🟩 throughput [+2454492.934op/s; +2470868.795op/s] or [+11.857%; +11.936%]

scenario:normalization/normalize_trace/test_trace

  • 🟥 execution_time [+16.543ns; +22.080ns] or [+6.525%; +8.709%]

scenario:redis/obfuscate_redis_string

  • 🟥 execution_time [+5.631µs; +5.946µs] or [+16.513%; +17.435%]

scenario:sql/obfuscate_sql_string

  • 🟥 execution_time [+10.891µs; +10.984µs] or [+16.612%; +16.754%]

scenario:tags/replace_trace_tags

  • 🟥 execution_time [+421.432ns; +429.195ns] or [+17.694%; +18.020%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 144.928µs 145.603µs ± 0.603µs 145.523µs ± 0.281µs 145.787µs 146.290µs 147.303µs 151.601µs 4.18% 5.354 47.929 0.41% 0.043µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [145.520µs; 145.687µs] or [-0.057%; +0.057%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.269µs 4.285µs ± 0.005µs 4.285µs ± 0.001µs 4.286µs 4.289µs 4.292µs 4.351µs 1.56% 8.831 106.900 0.13% 0.000µs 1 200
credit_card/is_card_number/ throughput 229805881.967op/s 233369179.725op/s ± 295000.280op/s 233381224.487op/s ± 56413.407op/s 233437886.980op/s 233630760.607op/s 233725898.979op/s 234273606.278op/s 0.38% -8.712 105.129 0.13% 20859.670op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 96.760µs 98.487µs ± 1.132µs 98.174µs ± 0.574µs 98.943µs 100.549µs 101.468µs 104.952µs 6.90% 1.698 4.679 1.15% 0.080µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 9528210.209op/s 10154910.425op/s ± 114529.595op/s 10186026.514op/s ± 59509.426op/s 10237003.796op/s 10274765.482op/s 10291751.551op/s 10334861.555op/s 1.46% -1.577 3.844 1.13% 8098.465op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 91.122µs 92.923µs ± 0.638µs 92.965µs ± 0.361µs 93.333µs 93.569µs 93.693µs 98.084µs 5.51% 2.130 20.188 0.69% 0.045µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10195360.092op/s 10762101.080op/s ± 72933.374op/s 10756766.406op/s ± 41900.498op/s 10798198.592op/s 10879033.367op/s 10928218.187op/s 10974275.891op/s 2.02% -1.788 17.154 0.68% 5157.168op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.268µs 4.285µs ± 0.005µs 4.285µs ± 0.001µs 4.287µs 4.290µs 4.293µs 4.339µs 1.25% 6.670 75.437 0.11% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 230488173.755op/s 233355371.220op/s ± 259093.823op/s 233365286.915op/s ± 68345.837op/s 233423283.973op/s 233628709.669op/s 233742984.643op/s 234286916.551op/s 0.39% -6.560 73.983 0.11% 18320.700op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 83.097µs 83.840µs ± 0.293µs 83.828µs ± 0.173µs 83.990µs 84.354µs 84.564µs 84.711µs 1.05% 0.354 0.284 0.35% 0.021µs 1 200
credit_card/is_card_number/378282246310005 throughput 11804835.379op/s 11927564.272op/s ± 41615.487op/s 11929226.287op/s ± 24659.216op/s 11954353.505op/s 11989075.500op/s 12016839.633op/s 12034063.620op/s 0.88% -0.332 0.271 0.35% 2942.659op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.965µs 59.058µs ± 0.035µs 59.056µs ± 0.019µs 59.078µs 59.120µs 59.146µs 59.155µs 0.17% 0.069 0.349 0.06% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16904840.960op/s 16932655.914op/s ± 10085.996op/s 16933163.112op/s ± 5499.373op/s 16938036.006op/s 16949896.193op/s 16957516.825op/s 16959169.104op/s 0.15% -0.064 0.348 0.06% 713.188op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.832µs 6.842µs ± 0.004µs 6.841µs ± 0.001µs 6.843µs 6.848µs 6.850µs 6.861µs 0.28% 0.699 3.787 0.05% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145754007.313op/s 146160124.455op/s ± 77238.935op/s 146167916.142op/s ± 28911.387op/s 146191897.321op/s 146292183.862op/s 146336526.019op/s 146369803.609op/s 0.14% -0.691 3.756 0.05% 5461.617op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.268µs 4.285µs ± 0.002µs 4.285µs ± 0.001µs 4.286µs 4.288µs 4.289µs 4.295µs 0.23% -1.870 15.824 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232827268.203op/s 233376777.209op/s ± 125020.163op/s 233373955.467op/s ± 47976.295op/s 233418661.823op/s 233568002.237op/s 233709704.672op/s 234303544.760op/s 0.40% 1.893 15.971 0.05% 8840.260op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 75.745µs 76.262µs ± 0.212µs 76.244µs ± 0.144µs 76.389µs 76.572µs 76.644µs 77.594µs 1.77% 1.202 6.459 0.28% 0.015µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 12887575.528op/s 13112810.362op/s ± 36272.965op/s 13115772.477op/s ± 24655.873op/s 13139869.331op/s 13164049.180op/s 13177513.164op/s 13202228.536op/s 0.66% -1.145 6.062 0.28% 2564.886op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.904µs 66.273µs ± 0.134µs 66.261µs ± 0.090µs 66.362µs 66.500µs 66.585µs 66.617µs 0.54% 0.191 -0.295 0.20% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15011231.085op/s 15089144.961op/s ± 30520.049op/s 15091799.898op/s ± 20595.372op/s 15110834.471op/s 15135885.219op/s 15150129.947op/s 15173634.614op/s 0.54% -0.181 -0.296 0.20% 2158.093op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.273µs 4.285µs ± 0.002µs 4.285µs ± 0.001µs 4.286µs 4.288µs 4.289µs 4.290µs 0.12% -1.642 8.646 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 233078514.805op/s 233363496.035op/s ± 103114.724op/s 233359057.154op/s ± 48705.033op/s 233406418.678op/s 233542249.477op/s 233645771.991op/s 234033716.498op/s 0.29% 1.652 8.716 0.04% 7291.312op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.595µs 63.032µs ± 0.181µs 63.012µs ± 0.120µs 63.154µs 63.373µs 63.477µs 63.596µs 0.93% 0.399 0.213 0.29% 0.013µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15724253.167op/s 15865107.676op/s ± 45604.495op/s 15869868.674op/s ± 30306.228op/s 15896538.132op/s 15934485.072op/s 15952368.671op/s 15975737.778op/s 0.67% -0.381 0.192 0.29% 3224.725op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.977µs 59.063µs ± 0.035µs 59.059µs ± 0.016µs 59.075µs 59.135µs 59.162µs 59.204µs 0.25% 0.943 2.445 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16890626.438op/s 16931192.447op/s ± 9918.401op/s 16932129.253op/s ± 4565.216op/s 16936541.742op/s 16944588.995op/s 16953698.415op/s 16955694.770op/s 0.14% -0.937 2.431 0.06% 701.337op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.832µs 6.842µs ± 0.004µs 6.841µs ± 0.002µs 6.843µs 6.851µs 6.852µs 6.854µs 0.19% 0.497 0.534 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145891148.439op/s 146166357.497op/s ± 91033.308op/s 146168931.794op/s ± 49308.932op/s 146221834.585op/s 146306997.967op/s 146363261.350op/s 146377497.353op/s 0.14% -0.493 0.530 0.06% 6437.027op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.284µs; 4.286µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/ throughput [233328295.524op/s; 233410063.927op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [98.330µs; 98.644µs] or [-0.159%; +0.159%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10139037.725op/s; 10170783.126op/s] or [-0.156%; +0.156%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [92.835µs; 93.011µs] or [-0.095%; +0.095%] None None None
credit_card/is_card_number/ 378282246310005 throughput [10751993.216op/s; 10772208.945op/s] or [-0.094%; +0.094%] None None None
credit_card/is_card_number/37828224631 execution_time [4.285µs; 4.286µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/37828224631 throughput [233319463.308op/s; 233391279.132op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/378282246310005 execution_time [83.800µs; 83.881µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/378282246310005 throughput [11921796.766op/s; 11933331.778op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.053µs; 59.062µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16931258.092op/s; 16934053.736op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.841µs; 6.842µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 throughput [146149419.882op/s; 146170829.029op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.285µs; 4.285µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ throughput [233359450.617op/s; 233394103.802op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [76.233µs; 76.291µs] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13107783.278op/s; 13117837.446op/s] or [-0.038%; +0.038%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.254µs; 66.292µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15084915.176op/s; 15093374.747op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.285µs; 4.285µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233349205.326op/s; 233377786.744op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [63.007µs; 63.057µs] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15858787.331op/s; 15871428.020op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.058µs; 59.067µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16929817.852op/s; 16932567.042op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.841µs; 6.842µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146153741.156op/s; 146178973.838op/s] or [-0.009%; +0.009%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 260.031ns 272.843ns ± 15.818ns 265.967ns ± 3.538ns 275.944ns 308.538ns 325.116ns 326.324ns 22.69% 1.894 2.728 5.78% 1.119ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [270.650ns; 275.035ns] or [-0.803%; +0.803%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 427.844µs 429.692µs ± 1.220µs 429.503µs ± 0.353µs 429.873µs 430.864µs 435.049µs 436.312µs 1.59% 3.188 12.102 0.28% 0.086µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 2291938.667op/s 2327265.208op/s ± 6546.793op/s 2328271.225op/s ± 1911.040op/s 2330131.112op/s 2333803.249op/s 2335426.186op/s 2337302.970op/s 0.39% -3.155 11.902 0.28% 462.928op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 469.606µs 470.677µs ± 0.855µs 470.601µs ± 0.255µs 470.847µs 471.246µs 472.176µs 478.811µs 1.74% 7.483 65.709 0.18% 0.060µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2088506.050op/s 2124604.329op/s ± 3806.596op/s 2124944.025op/s ± 1151.776op/s 2126094.526op/s 2127405.191op/s 2128327.066op/s 2129446.115op/s 0.21% -7.419 64.935 0.18% 269.167op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 161.467µs 162.527µs ± 0.341µs 162.567µs ± 0.211µs 162.766µs 162.986µs 163.204µs 163.508µs 0.58% -0.568 0.604 0.21% 0.024µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 6115902.751op/s 6152834.641op/s ± 12943.387op/s 6151318.092op/s ± 7977.530op/s 6159979.426op/s 6177998.413op/s 6190655.018op/s 6193224.669op/s 0.68% 0.582 0.620 0.21% 915.236op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.599µs 45.770µs ± 0.084µs 45.768µs ± 0.044µs 45.809µs 45.876µs 45.945µs 46.377µs 1.33% 2.026 12.829 0.18% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21562495.200op/s 21848639.518op/s ± 40029.475op/s 21849291.081op/s ± 20844.807op/s 21871457.476op/s 21906352.459op/s 21923804.482op/s 21930414.195op/s 0.37% -1.968 12.341 0.18% 2830.511op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 42.989µs 43.173µs ± 0.068µs 43.167µs ± 0.045µs 43.215µs 43.297µs 43.337µs 43.355µs 0.43% 0.140 0.130 0.16% 0.005µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 23065413.513op/s 23162807.349op/s ± 36545.675op/s 23165736.389op/s ± 23893.031op/s 23186832.258op/s 23214212.840op/s 23251176.003op/s 23261588.190op/s 0.41% -0.130 0.129 0.16% 2584.169op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [429.523µs; 429.861µs] or [-0.039%; +0.039%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [2326357.885op/s; 2328172.530op/s] or [-0.039%; +0.039%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [470.559µs; 470.796µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2124076.771op/s; 2125131.887op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [162.480µs; 162.575µs] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [6151040.812op/s; 6154628.470op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.758µs; 45.781µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21843091.817op/s; 21854187.218op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [43.163µs; 43.182µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [23157742.470op/s; 23167872.228op/s] or [-0.022%; +0.022%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.431µs 3.340µs ± 1.482µs 3.140µs ± 0.023µs 3.163µs 3.770µs 14.480µs 15.496µs 393.45% 7.464 56.337 44.25% 0.105µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.135µs; 3.546µs] or [-6.148%; +6.148%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.445µs 5.505µs ± 0.025µs 5.505µs ± 0.020µs 5.524µs 5.547µs 5.552µs 5.555µs 0.91% 0.116 -0.982 0.46% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.502µs; 5.509µs] or [-0.064%; +0.064%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 39.329µs 39.890µs ± 0.841µs 39.544µs ± 0.120µs 39.675µs 41.598µs 41.674µs 44.161µs 11.67% 1.947 3.200 2.10% 0.059µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [39.773µs; 40.006µs] or [-0.292%; +0.292%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 57.601ms 57.912ms ± 0.205ms 57.899ms ± 0.115ms 57.993ms 58.207ms 58.511ms 59.380ms 2.56% 2.625 13.553 0.35% 0.014ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [57.884ms; 57.941ms] or [-0.049%; +0.049%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.861µs 28.088µs ± 13.733µs 19.061µs ± 0.103µs 36.054µs 46.146µs 55.446µs 145.214µs 661.85% 3.866 27.234 48.77% 0.971µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.185µs; 29.992µs] or [-6.776%; +6.776%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 210.944µs 216.964µs ± 2.770µs 216.875µs ± 2.080µs 219.094µs 221.253µs 222.501µs 224.196µs 3.38% -0.026 -0.584 1.27% 0.196µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4460386.195op/s 4609816.544op/s ± 58902.765op/s 4610952.193op/s ± 44086.623op/s 4650855.738op/s 4708609.012op/s 4735181.155op/s 4740603.400op/s 2.81% 0.080 -0.588 1.27% 4165.054op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 20.695µs 21.029µs ± 0.135µs 21.022µs ± 0.088µs 21.110µs 21.262µs 21.341µs 21.352µs 1.57% 0.213 -0.377 0.64% 0.010µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 46834592.437op/s 47556158.647op/s ± 304741.873op/s 47568140.845op/s ± 198542.658op/s 47766599.938op/s 48046361.973op/s 48154765.813op/s 48319794.687op/s 1.58% -0.183 -0.385 0.64% 21548.504op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 13.206µs 13.427µs ± 0.080µs 13.418µs ± 0.055µs 13.481µs 13.554µs 13.609µs 13.647µs 1.71% 0.187 -0.209 0.59% 0.006µs 1 200
normalization/normalize_name/normalize_name/good throughput 73276817.134op/s 74481487.827op/s ± 440982.250op/s 74527394.293op/s ± 304503.537op/s 74789321.201op/s 75155769.281op/s 75475148.513op/s 75723065.125op/s 1.60% -0.156 -0.211 0.59% 31182.154op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [216.580µs; 217.348µs] or [-0.177%; +0.177%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4601653.187op/s; 4617979.901op/s] or [-0.177%; +0.177%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [21.010µs; 21.047µs] or [-0.089%; +0.089%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [47513924.355op/s; 47598392.940op/s] or [-0.089%; +0.089%] None None None
normalization/normalize_name/normalize_name/good execution_time [13.416µs; 13.438µs] or [-0.082%; +0.082%] None None None
normalization/normalize_name/normalize_name/good throughput [74420371.928op/s; 74542603.725op/s] or [-0.082%; +0.082%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.751µs 2.807µs ± 0.021µs 2.804µs ± 0.008µs 2.816µs 2.850µs 2.865µs 2.867µs 2.23% 0.380 1.098 0.75% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.804µs; 2.810µs] or [-0.105%; +0.105%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.242ms 6.259ms ± 0.006ms 6.259ms ± 0.005ms 6.263ms 6.268ms 6.274ms 6.278ms 0.30% 0.282 0.014 0.10% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.258ms; 6.260ms] or [-0.014%; +0.014%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 16fe287 1739809254 r1viollet/unwind_rfc
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 76.323µs 76.501µs ± 0.175µs 76.487µs ± 0.050µs 76.532µs 76.613µs 76.834µs 78.106µs 2.12% 7.291 62.955 0.23% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [76.477µs; 76.525µs] or [-0.032%; +0.032%] None None None

Baseline

Omitted due to size.

@r1viollet r1viollet force-pushed the r1viollet/unwind_rfc branch from 31cc413 to a1d6bf9 Compare February 11, 2025 18:41
@r1viollet
crashtracking custom unwinding
6f68505 
Re-Add the capability to emit symbols in process
@r1viollet r1viollet force-pushed the r1viollet/unwind_rfc branch from a1d6bf9 to 6f68505 Compare February 13, 2025 08:49
r1viollet
r1viollet commented Feb 14, 2025
View reviewed changes
crashtracker/build.rs
println!("cargo:rustc-link-search=native=/usr/lib/x86_64-linux-gnu");
if target.contains("musl") {
// possibly lzma compressed symbol tables. Do we really need it ?
println!("cargo:rustc-link-lib=static=lzma");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LZMA should not be needed with appropriate libunwind build flags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where you no longer need a standard install of libunwind if you want to optimize for size.
Then should we have the install of libunwind as part of the project ?

@r1viollet
crashtracking - libunwind
a101a9b 
Switch the default to OFF
@r1viollet r1viollet force-pushed the r1viollet/unwind_rfc branch from 2b05c45 to a101a9b Compare February 17, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsn danielsn danielsn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
crashtracker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r1viollet @danielsn