Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds feature decorator for symbol database #4142

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

tylfin
Copy link
Contributor

@tylfin tylfin commented Feb 19, 2025

Motivation

This pull request introduces new functionality to support the debugger_symdb feature in the test framework. The most significant changes include adding a new feature marker and updating the Test_Debugger_SymDb class to use this new feature.

Changes

  • tests/debugger/test_debugger_symdb.py: Added the @features.debugger_symdb decorator to the Test_Debugger_SymDb class to enable tests for the new debugger symbol database feature.

  • utils/_features.py: Introduced a new static method debugger_symdb in the _features class to mark tests with the feature ID 370, facilitating the probing of budgets for the debugger symbol database.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@tylfin tylfin force-pushed the tyler.finethy/add-feature-debugger-symdb branch from e77ec1f to c6c3227 Compare February 19, 2025 18:14
@tylfin tylfin marked this pull request as ready for review February 20, 2025 17:17
@tylfin tylfin requested review from a team as code owners February 20, 2025 17:17
@tylfin tylfin requested a review from shurivich February 20, 2025 18:56
@tylfin tylfin merged commit d0b155b into main Feb 21, 2025
336 checks passed
@tylfin tylfin deleted the tyler.finethy/add-feature-debugger-symdb branch February 21, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants