Skip to content

Conversation

@cbeauchesne
Copy link
Collaborator

Motivation

Pave the way for #5581

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

docs/scenarios/docker_fixtures.md                                       @DataDog/system-tests-core
utils/_context/_scenarios/_docker_fixtures.py                           @DataDog/system-tests-core
tests/parametric/conftest.py                                            @DataDog/system-tests-core @DataDog/apm-sdk-capabilities
utils/_context/_scenarios/parametric.py                                 @DataDog/system-tests-core
utils/docker_fixtures/__init__.py                                       @DataDog/system-tests-core
utils/docker_fixtures/_core.py                                          @DataDog/system-tests-core
utils/scripts/libraries_and_scenarios_rules.yml                         @DataDog/system-tests-core

@cbeauchesne cbeauchesne marked this pull request as ready for review October 25, 2025 14:41
@cbeauchesne cbeauchesne requested review from a team as code owners October 25, 2025 14:41
@cbeauchesne cbeauchesne requested review from mhlidd and removed request for a team October 25, 2025 14:41
@cbeauchesne cbeauchesne merged commit bd28672 into main Oct 25, 2025
406 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/docker_fixtures_scenarios branch October 25, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants