[ruby] Enable Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation#7112
Draft
p-datadog wants to merge 2 commits into
Draft
[ruby] Enable Test_Debugger_InProduct_Enablement_Dynamic_Instrumentation#7112p-datadog wants to merge 2 commits into
p-datadog wants to merge 2 commits into
Conversation
dd-trace-rb v2.36.0 implements implicit DI enablement: APM_TRACING RC with dynamic_instrumentation_enabled=true starts the always-built DI component, =false stops it, and null preserves current state. Pin to v2.36.0 on the three Rails-based weblogs that have a working debugger_controller.rb fixture (rails72, rails80, uds-rails). The other weblogs and the three sibling tests (Code Origin, Code Origin Default On, Exception Replay) stay missing_feature — they are out of scope for the Ruby implicit-enablement work (Exception Replay, Code Origin, and Distributed Debugger are not implemented in Ruby DI). Tracer change: DataDog/dd-trace-rb#5525
Contributor
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dd-trace-rb v2.36.0 (DataDog/dd-trace-rb#5525) implements implicit DI enablement for Ruby: an
APM_TRACINGRC payload withdynamic_instrumentation_enabled: truestarts the always-built DI component,falsestops it, andnullpreserves current state.This system test verifies the full round trip — RC delivery to tracer, tracer-side
start!/stop!, and probe install/remove behavior — that already passes for Java, Python, .NET, and Node.js. Ruby has been opted out viamissing_featureand should now run.Changes
manifests/ruby.yml— changeTest_Debugger_InProduct_Enablement_Dynamic_Instrumentationfrommissing_featuretov2.36.0-devon the three Rails-based weblogs that have a workingdebugger_controller.rbfixture (rails72,rails80,uds-rails):The three sibling tests in the same file stay
missing_feature— they are out of scope for the Ruby work:Test_Debugger_InProduct_Enablement_Code_Origin— Code Origin is not implemented in Ruby DI.Test_Debugger_InProduct_Enablement_Code_Origin_Default_On— same; alreadyirrelevantper dotnet rollout comment.Test_Debugger_InProduct_Enablement_Exception_Replay— Exception Replay is not implemented in Ruby DI.Verification
The probe template targets line 20 of the language's debugger controller. In Ruby that resolves to
utils/build/docker/ruby/shared/rails/app/controllers/debugger_controller.rb, which already hasdef log_probe / render inline: 'Log probe' # This needs to be line 20.Tracer-side coverage of the same flow lives in dd-trace-rb/spec/datadog/di/integration/implicit_enablement_spec.rb — those tests pass on the enablement branch.
Notes
The
-devsuffix tracks the unreleased dd-trace-rb #5525; other tests in this manifest already use-devversions, so no version bump is required before merge.The reviewer checklist's "Anything but
tests/ormanifests/is modified" item is satisfied — onlymanifests/ruby.ymlchanges.