test(otel): OTel HTTP semantics coverage against the cross-tracer RFC - #7455
Merged
Conversation
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 402c665 | Docs | View more details | Give us feedback! |
This was referenced Aug 17, 2026
9 tasks
marcotc
reviewed
Aug 19, 2026
marcotc
reviewed
Aug 19, 2026
marcotc
reviewed
Aug 19, 2026
Contributor
|
|
marcotc
reviewed
Aug 19, 2026
Member
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 330d1e1e0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
|
@codex review |
tabgok
requested review from
xlamorlette-datadog
and removed request for
tabgok
August 21, 2026 12:43
xlamorlette-datadog
approved these changes
Aug 21, 2026
xlamorlette-datadog
left a comment
Contributor
There was a problem hiding this comment.
OK for the C++ part.
cbeauchesne
approved these changes
Aug 21, 2026
Co-authored-by: Ayan Khan <khanayan_123@hotmail.com> Co-authored-by: Zach Montoya <zach.montoya@datadoghq.com> Co-authored-by: Maximo Bautista <max.bautista97@gmail.com>
marcotc
force-pushed
the
otel-semantics-system-tests-v2
branch
from
August 21, 2026 22:55
69d0136 to
39e8ffe
Compare
Member
|
I rewrote commit history (!) to fix previous unsigned commits. |
This was referenced Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds tests for HTTP OpenTelemetry semantic conventions enabled by
DD_TRACE_OTEL_SEMANTICS_ENABLEDand exported over OTLP.Coverage includes HTTP server and client attributes, span naming and status (and custom error-status configuration), and trace metrics.
Scenarios
OTEL_SEMANTICS_OTLPTest_OtelSemantics_Spans_Http_ServerOTEL_SEMANTICS_OTLPTest_OtelSemantics_Spans_Http_ClientOTEL_SEMANTICS_OTLP_CUSTOM_ERROR_STATUSESTest_OtelSemantics_OTLP_Spans_Http_ErrorStatusConfigurationOTEL_SEMANTICS_OTLP_TRACE_METRICSTest_OtelSemantics_OTLP_TraceMetricsOTEL_SEMANTICS_OTLP_SAMPLING_RULESTest_OtelSemantics_SamplingRulesTest_OtelSemantics_Spans_Http_Servertest_otel_attributes_presenttest_datadog_attributes_absenttest_span_name_with_routetest_span_name_route_invariancetest_span_name_without_routetest_span_name_unknown_method_OTHERattributes andHTTPin the span name.test_status_500_no_exception_is_status_code_errortest_status_400_is_not_errortest_status_3xx_is_not_errortest_url_query_present_with_query_stringurl.queryis emitted when a query string is present.test_url_query_absent_without_query_stringurl.queryis omitted when no query string exists.test_url_query_obfuscationtest_user_agenttest_client_addresstest_network_peer_addresstest_server_addresstest_server_portserver.portis emitted as an OTLP integer.test_http_endpoint_retainedtest_span_kind_is_serverSERVER.Test_OtelSemantics_Spans_Http_Clienttest_otel_attributes_presenttest_datadog_attributes_absenttest_peer_service_suppressedtest_span_name_is_methodtest_span_name_unknown_method_OTHERattributes andHTTPin the span name.test_span_kind_is_clientCLIENT.test_status_400_is_errortest_status_500_is_errortest_status_3xx_not_errortest_url_full_credential_redactionurl.fullare removed or redacted.test_url_full_query_obfuscationurl.fullare obfuscated.Test_OtelSemantics_OTLP_Spans_Http_ErrorStatusConfigurationtest_server_error_statuses_config_overridestest_server_error_statuses_config_excludes_500test_client_error_statuses_config_overridestest_client_error_statuses_config_excludes_500Test_OtelSemantics_OTLP_TraceMetricstest_trace_metric_agrees_with_client_errortest_trace_metric_agrees_with_client_successstatus.codeunset.test_trace_metric_agrees_with_server_errortest_trace_metric_agrees_with_server_successstatus.codeunset.Test_OtelSemantics_SamplingRulestest_otel_span_name_is_available_to_sampling_rulestest_server_span_name_is_available_before_client_sampling