-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added accessibility for charts #11801
base: bugfix
Are you sure you want to change the base?
Added accessibility for charts #11801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
DryRun Security SummaryThe pull request adds accessibility features to templates while introducing potential security risks through XSS vulnerabilities in metrics.js and possible information exposure in metrics data. Expand for full summaryThe PR introduces accessibility improvements across multiple template files, focusing on enhancing screen reader support and providing alternative data representations for charts and graphs. Security Vulnerabilities:
No other direct security vulnerabilities were identified in the reviewed files. Code AnalysisWe ran
Overall Riskiness🔴 Risk threshold exceeded. We've notified @mtesauro, @grendel513. |
@littlesvensson we had some issues with unit tests a few days ago. Please update your branch with the latest version of |
96a10e9
to
e6bcc40
Compare
Closing and reopening to see if I can make AccessLint happy... |
Whelp, sometimes AccessLint gets stuck. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Fixes #11798
Description
Adding accessibility features for graphs and charts. Basically no visual difference in appearance just added some aria attributes, and tables, with description within the sr-only class
Before

After
tables for complex graphics example
