-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64 builds: unit tests #11830
base: dev
Are you sure you want to change the base?
arm64 builds: unit tests #11830
Conversation
DryRun Security SummaryMultiple security vulnerabilities were identified across DefectDojo's GitHub Actions workflows, including information disclosure risks, insufficient encryption, exposed credentials, and lack of proper security controls in integration tests, Kubernetes tests, release processes, and Docker image builds. Expand for full summaryThis PR modifies multiple GitHub Actions workflows for DefectDojo, focusing on cross-platform testing, runner configuration, and workflow optimization. Security findings include:
These findings suggest multiple configuration-level security considerations that should be addressed to improve the workflow's security posture. Code AnalysisWe ran |
d70b1fc
to
5487fdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
1 similar comment
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Hi,
The 25% refund sounds good to me.
I have a suggestion as well. It would be nice to be able to set the Monitor to be in Celsius always and not switch when you press the button to measure Co2.
Valentijn
…________________________________
From: github-actions[bot] ***@***.***>
Sent: Thursday, February 20, 2025 00:49
To: DefectDojo/django-DefectDojo ***@***.***>
Cc: valentijnscholten ***@***.***>; Author ***@***.***>
Subject: Re: [DefectDojo/django-DefectDojo] arm64 builds: unit tests (PR #11830)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
—
Reply to this email directly, view it on GitHub<#11830 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABBYSQQIKV5OIGVVFL4EHZL2QUJ7LAVCNFSM6AAAAABXH23MZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZQGAZTCNBRHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[github-actions[bot]]github-actions[bot] left a comment (DefectDojo/django-DefectDojo#11830)<#11830 (comment)>
This pull request has conflicts, please resolve those before we can evaluate the pull request.
—
Reply to this email directly, view it on GitHub<#11830 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABBYSQQIKV5OIGVVFL4EHZL2QUJ7LAVCNFSM6AAAAABXH23MZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZQGAZTCNBRHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@valentijnscholten I would also like a 25% refund on my monitor 😂 |
Consider it done. @Maffooch 😅 |
Description
This PR takes another step towards publishing arm64 images (continuing on from #11673)
Most tutorials for multi platform builds just add a few lines to install Qemy and add
-platforms: linux/amd64,linux/arm64
and are done. Unfortunately our nice python wheels such asuwsgi
don't get build successfully under Qemu.So we have run the builds natively on Githubs
arm64
runners.Steps taken (before I knew that native runners was the only way):
arm64
with Qemu -> FAILEDuwsgi
so we don't have to build them -> FAILEDAt first the PyOpenSSL error seemed related to ARM64 as I had no other reports.
So I thought it was a good idea to run the unit tests also on
arm64
runners to make sure they work.Afterwards I found out the PyOpenSSL error was also present on
amd64
and I fixed that.Now that we have unit tests working in GitHub actions anyway, I think it's good to have them running.
At least for a while during the next couple of releases to see if anything pops up on these
arm64
builds.The integration test are not run for
arm64
. These tests are fully based on Chrome for which there is noarm64
build.I tried to switch the integration tests to Chromium, but that would need some more work: #11810 and might not be worth it.
Test results
GitHub usually doesn't take workflow definitions from forks, so I created a branch in the Defect Dojo repository.
GitHub might still not pick up the workflow changes as it may look at
master
. Let's see if we have to wait until the next monthly release.Next steps (in another PR)