Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): add spec.strategy in deployment django #11859

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Mistikan
Copy link

@Mistikan Mistikan commented Feb 20, 2025

Description

Use case - when I deploy a chart with pvc (ReadWriteOnce), I can't update my Deployment:

Multi-Attach error for volume "<volume-name>" Volume is already exclusively attached to one node and can't be attached to another

Test results

...
spec:
...
  strategy:
    type: Recreate

Documentation

Empty.

Checklist

This checklist is for your information.

  • Make sure to rebase your PR against the very latest dev.
  • Features/Changes should be submitted against the dev.
  • Give a meaningful name to your PR, as it may end up being used in the release notes.

@github-actions github-actions bot added the helm label Feb 20, 2025
Copy link

DryRun Security Summary

This PR enhances DefectDojo's Helm configuration by adding flexible deployment strategies, improving security configurations including secret management, secure cookie handling, security contexts, and configurable health probes.

Expand for full summary

This PR updates Helm configuration for DefectDojo's Django deployment, adding a flexible deployment strategy configuration and enhancing configuration options.

Security Findings:

  1. Secrets Management Identified: Multiple secret references detected in django-deployment.yaml, including:
    • DD_CELERY_BROKER_PASSWORD
    • DD_DATABASE_PASSWORD
    • DD_SECRET_KEY
    • DD_CREDENTIAL_AES_256_KEY
  2. Secure Cookie Configuration: Conditional secure cookie settings based on TLS enablement for DD_SESSION_COOKIE_SECURE and DD_CSRF_COOKIE_SECURE
  3. Configurable Security Context: Optional security context support for containers
  4. Configurable Probe Security: Liveness, readiness, and startup probes can be configured for enhanced system health monitoring

Code Analysis

We ran 9 analyzers against 2 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@Maffooch Maffooch requested a review from kiblik February 21, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant