Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Add secret annotations #11860

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

al-cheb
Copy link
Contributor

@al-cheb al-cheb commented Feb 20, 2025

Description

Allow adding annotations to secret resources.

E.g.: A Kubernetes mutating webhook that makes direct secret injection using annotations - https://bank-vaults.dev/docs/mutating-webhook/annotations/

Allow adding annotations to secret resources.
@github-actions github-actions bot added the helm label Feb 20, 2025
Copy link

DryRun Security Summary

A pull request adds optional secret annotations to DefectDojo's Helm chart templates while introducing potential security considerations around annotation injection, external dependencies, insecure resource fetching, and password generation methods.

Expand for full summary

The pull request adds optional secret annotations to multiple Helm chart templates for DefectDojo, allowing dynamic metadata configuration across various secret resources. Security findings include:

  1. Annotation Injection Potential: Multiple files (extra-secret.yaml, secret-postgresql-ha-pgpool.yaml, secret-postgresql-ha.yaml, secret-postgresql.yaml, secret.yaml, secret-redis.yaml) allow arbitrary annotation injection without validation, which could expose sensitive metadata or enable configuration manipulation.

  2. External Dependency Risks: The Chart.yaml file uses external Bitnami chart repositories, which could potentially introduce unknown security risks.

  3. Insecure Resource Fetching: Chart.yaml uses an HTTP (not HTTPS) icon URL, which is a potential security concern for resource integrity.

  4. Weak Password Generation: Several secret templates use randAlphaNum with limited character lengths (10-16 characters), which might not meet robust password complexity requirements.

No critical vulnerabilities were identified, but careful annotation and configuration validation is recommended.

Code Analysis

We ran 9 analyzers against 8 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@Maffooch Maffooch requested a review from kiblik February 21, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant