add justbet fees & volume aggregator #2706

SirCreed · 2025-03-26T10:11:58Z

No description provided.

…add-justbet-fees-volume

llamabutler · 2025-03-26T10:14:56Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts aggregators justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Tue, 25 Mar 2025 07:44:52 GMT
End Date:	Wed, 26 Mar 2025 07:44:52 GMT
---------------------------------------------------

[Error: TypeError: Cannot read properties of null (reading 'call')] {
  _underlyingError: "TypeError: Cannot read properties of null (reading 'call')",
  _isCustomError: true,
  chain: 'winr'
}

llamabutler · 2025-03-26T10:15:03Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Tue, 25 Mar 2025 07:44:58 GMT
End Date:	Wed, 26 Mar 2025 07:44:58 GMT
---------------------------------------------------

[Error: TypeError: Cannot read properties of null (reading 'call')] {
  _underlyingError: "TypeError: Cannot read properties of null (reading 'call')",
  _isCustomError: true,
  chain: 'winr'
}

llamabutler · 2025-03-26T10:16:33Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts aggregators justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Tue, 25 Mar 2025 07:46:30 GMT
End Date:	Wed, 26 Mar 2025 07:46:30 GMT
---------------------------------------------------

[Error: TypeError: Cannot read properties of null (reading 'call')] {
  _underlyingError: "TypeError: Cannot read properties of null (reading 'call')",
  _isCustomError: true,
  chain: 'winr'
}

llamabutler · 2025-03-26T10:16:39Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Tue, 25 Mar 2025 07:46:35 GMT
End Date:	Wed, 26 Mar 2025 07:46:35 GMT
---------------------------------------------------

[Error: TypeError: Cannot read properties of null (reading 'call')] {
  _underlyingError: "TypeError: Cannot read properties of null (reading 'call')",
  _isCustomError: true,
  chain: 'winr'
}

SirCreed · 2025-03-26T10:22:47Z

I added winr rpc to .env file while running tests

g1nt0ki · 2025-03-26T21:20:00Z

fees/justbet/index.ts

+
+  return {
+    revenue: amountUsd,
+    fees: (amountUsd * 60) / 100,


hi, how can the revenue be higher than the fees charged to the user?

you’re right, the fee calculation should be revenue, and the revenue calculation should be a fee. I will change it.

llamabutler · 2025-03-26T21:47:18Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts aggregators justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Tue, 25 Mar 2025 19:17:14 GMT
End Date:	Wed, 26 Mar 2025 19:17:14 GMT
---------------------------------------------------

WINR 👇
Backfill start time: 20/11/2024
Total volume: 90.53 M
Daily volume: -446781
End timestamp: 1743016633 (2025-03-26T19:17:13.000Z)

g1nt0ki · 2025-03-26T21:47:20Z

aggregators/justbet/index.ts

this is not an aggregator, closer to a dex?

also, any idea why I am getting negative value for today after the refactor?

Yes, you’re right. I’ll start by moving to the DEX section first. The fromApi caches cause the returnEpochResultInUsdByAddress function to always calculate using the latest price of the vault token address. As a result, volume fluctuations appear negative due to price changes. To address this, we should use the returnEpochResultInActiveEpochByAddress function and convert the values to USD using the same price for both yesterday and today. I'll send updates

llamabutler · 2025-03-26T21:47:25Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Tue, 25 Mar 2025 19:17:19 GMT
End Date:	Wed, 26 Mar 2025 19:17:19 GMT
---------------------------------------------------

WINR 👇
Backfill start time: 20/11/2024
Daily revenue: 1.87 k
Total revenue: 516.04 k
Daily holders revenue: 374
Total holders revenue: 103.21 k
End timestamp: 1743016638 (2025-03-26T19:17:18.000Z)

fix: re calculate fees

llamabutler · 2025-03-28T10:56:02Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Thu, 27 Mar 2025 08:25:56 GMT
End Date:	Fri, 28 Mar 2025 08:25:56 GMT
---------------------------------------------------

WINR 👇
Backfill start time: 20/11/2024
Total volume: 88.95 M
Daily volume: 0
End timestamp: 1743150355 (2025-03-28T08:25:55.000Z)

llamabutler · 2025-03-28T10:56:09Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Thu, 27 Mar 2025 08:26:03 GMT
End Date:	Fri, 28 Mar 2025 08:26:03 GMT
---------------------------------------------------

WINR 👇
Backfill start time: 20/11/2024
Daily fees: -4344
Total fees: 500.04 k
Daily revenue: -2606
Total revenue: 300.02 k
Daily holders revenue: -869
Total holders revenue: 100.01 k
End timestamp: 1743150362 (2025-03-28T08:26:02.000Z)

llamabutler · 2025-03-31T14:32:15Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts dexs justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Sun, 30 Mar 2025 12:02:07 GMT
End Date:	Mon, 31 Mar 2025 12:02:07 GMT
---------------------------------------------------

WINR 👇
Backfill start time: 20/11/2024
Total volume: 86.14 M
Daily volume: 0
End timestamp: 1743422526 (2025-03-31T12:02:06.000Z)

llamabutler · 2025-03-31T14:32:22Z

The justbet adapter exports:

> [email protected] test
> ts-node --transpile-only cli/testAdapter.ts fees justbet

🦙 Running JUSTBET adapter 🦙
---------------------------------------------------
Start Date:	Sun, 30 Mar 2025 12:02:16 GMT
End Date:	Mon, 31 Mar 2025 12:02:16 GMT
---------------------------------------------------

WINR 👇
Backfill start time: 20/11/2024
Daily fees: -2141
Total fees: 480.88 k
Daily revenue: -1285
Total revenue: 288.53 k
Daily holders revenue: -428
Total holders revenue: 96.18 k
End timestamp: 1743422535 (2025-03-31T12:02:15.000Z)

SirCreed added 2 commits March 26, 2025 12:59

add justbet fees & volume aggregator

b559844

Merge branch 'master' of github.com:SirCreed/dimension-adapters into …

4965c0e

…add-justbet-fees-volume

rm auto formatted sections

a8e53ad

g1nt0ki self-assigned this Mar 26, 2025

g1nt0ki reviewed Mar 26, 2025

View reviewed changes

code refactor

376bc57

g1nt0ki reviewed Mar 26, 2025

View reviewed changes

fix: move justbet volume to dexs from aggregators

9b5cd99

fix: re calculate fees

Merge branch 'master' into add-justbet-fees-volume

ab319b3

g1nt0ki merged commit 0732eb8 into DefiLlama:master Mar 31, 2025
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add justbet fees & volume aggregator #2706

add justbet fees & volume aggregator #2706

SirCreed commented Mar 26, 2025

llamabutler commented Mar 26, 2025

llamabutler commented Mar 26, 2025

llamabutler commented Mar 26, 2025

llamabutler commented Mar 26, 2025

SirCreed commented Mar 26, 2025

g1nt0ki Mar 26, 2025

SirCreed Mar 28, 2025

llamabutler commented Mar 26, 2025

g1nt0ki Mar 26, 2025

g1nt0ki Mar 26, 2025

SirCreed Mar 28, 2025

llamabutler commented Mar 26, 2025

llamabutler commented Mar 28, 2025

llamabutler commented Mar 28, 2025

llamabutler commented Mar 31, 2025

llamabutler commented Mar 31, 2025

add justbet fees & volume aggregator #2706

add justbet fees & volume aggregator #2706

Conversation

SirCreed commented Mar 26, 2025

llamabutler commented Mar 26, 2025

llamabutler commented Mar 26, 2025

llamabutler commented Mar 26, 2025

llamabutler commented Mar 26, 2025

SirCreed commented Mar 26, 2025

g1nt0ki Mar 26, 2025

Choose a reason for hiding this comment

SirCreed Mar 28, 2025

Choose a reason for hiding this comment

llamabutler commented Mar 26, 2025

g1nt0ki Mar 26, 2025

Choose a reason for hiding this comment

g1nt0ki Mar 26, 2025

Choose a reason for hiding this comment

SirCreed Mar 28, 2025

Choose a reason for hiding this comment

llamabutler commented Mar 26, 2025

llamabutler commented Mar 28, 2025

llamabutler commented Mar 28, 2025

llamabutler commented Mar 31, 2025

llamabutler commented Mar 31, 2025