-
Notifications
You must be signed in to change notification settings - Fork 1.3k
FEAT-BERADROME: Change holders revenue method #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
FEAT-BERADROME: Change holders revenue method #3130
Conversation
The beradrome adapter exports:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @t0rbik thanks for the PR. the code is mostly good, but can you add a topics filter like here:
https://github.com/DefiLlama/dimension-adapters/blob/master/fees/beraborrow/index.ts#L163
this way, we filter logs while querying the rpc instead of pulling all the logs and then filtering on our end
@g1nt0ki thank you for taking a look. |
The beradrome adapter exports:
|
The beradrome adapter exports:
|
The beradrome adapter exports:
|
sorry, missed the message, can you switch back to on chain? we have added an indexer for berachain, you can pass |
The beradrome adapter exports:
|
Thank you. Should be done now! |
The beradrome adapter exports:
|
Previously added method has two issues:
RewardAdded
event includes leftovers from previous emissions.The fix is to get Distributor events to Beradrome Reward Vault. I couldn't find an api to filter by arg (topic) specifically in getLogs request.