-
Notifications
You must be signed in to change notification settings - Fork 5
Refresh timeseries automatically every 30s #1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Currently, the charts get recreated every time the data changes, which lead to frequent 'flickering' of the chart (see also this comment). Created this issue to look into this. |
The interval / automatic refresh still needs to be implemented for the elevation charts |
It still flickers sometimes. As far as I've been able to determine, this is due to the |
edb5851
to
223ceed
Compare
Has been fixed |
63cb968
to
5acd9c1
Compare
Has been fixed |
Has been fixed by removing the loading overlay. It might be nice to have some kind of loading indicator, somewhere, but we should pick that up in a separate issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The charts sometimes don't update when switching locations on the map.
Do not use the display config title as id (and v-for key) for all timeseries charts within that display
Draw and scale the chart at initiation, once the data is loaded
The indicator on chart level causes the chart to flicker in case the data is requested again
5acd9c1
to
933f020
Compare
Has been fixed by removing the debounced on the loading times series ids |
This needed for the isLoading check in the TimeSeriesChart
933f020
to
e428a9c
Compare
Description
Performs a timeseries request every 30 seconds if a chart is open, to keep the data up-to-date. The chart is prevented from being redrawn completely, because a redraw would reset the zoom and would create a noticeable/visible 'flicker' of the chart.