Skip to content

Refresh timeseries automatically every 30s #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 27, 2025
Merged

Conversation

amarkensteijn
Copy link
Collaborator

@amarkensteijn amarkensteijn commented Dec 17, 2024

Description

Performs a timeseries request every 30 seconds if a chart is open, to keep the data up-to-date. The chart is prevented from being redrawn completely, because a redraw would reset the zoom and would create a noticeable/visible 'flicker' of the chart.

@amarkensteijn amarkensteijn linked an issue Dec 17, 2024 that may be closed by this pull request
@amarkensteijn
Copy link
Collaborator Author

Currently, the charts get recreated every time the data changes, which lead to frequent 'flickering' of the chart (see also this comment). Created this issue to look into this.

@amarkensteijn
Copy link
Collaborator Author

The interval / automatic refresh still needs to be implemented for the elevation charts

@amarkensteijn
Copy link
Collaborator Author

It still flickers sometimes. As far as I've been able to determine, this is due to the v-show and the LoadingOverlay based on the isLoading prop. We should move the loading indicator to each indiviual series, e.g. in the legend tag. We could consider an initial loader indicator on the full chart panel when opening it for the first time, untill the chart config have loaded or untill as least one series has data. Something like this is done for the RWsOS viewer

@amarkensteijn amarkensteijn force-pushed the 1134-refresh-timeseries branch from edb5851 to 223ceed Compare January 9, 2025 14:21
@amarkensteijn
Copy link
Collaborator Author

The interval / automatic refresh still needs to be implemented for the elevation charts

Has been fixed

@amarkensteijn
Copy link
Collaborator Author

Currently, the charts get recreated every time the data changes, which lead to frequent 'flickering' of the chart (see also this comment). Created this issue to look into this.

Has been fixed

@amarkensteijn
Copy link
Collaborator Author

It still flickers sometimes. As far as I've been able to determine, this is due to the v-show and the LoadingOverlay based on the isLoading prop. We should move the loading indicator to each indiviual series, e.g. in the legend tag. We could consider an initial loader indicator on the full chart panel when opening it for the first time, untill the chart config have loaded or untill as least one series has data. Something like this is done for the RWsOS viewer

Has been fixed by removing the loading overlay. It might be nice to have some kind of loading indicator, somewhere, but we should pick that up in a separate issue

Copy link
Collaborator

@hvangeffen hvangeffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The charts sometimes don't update when switching locations on the map.

@amarkensteijn amarkensteijn force-pushed the 1134-refresh-timeseries branch from 5acd9c1 to 933f020 Compare March 27, 2025 12:36
@amarkensteijn
Copy link
Collaborator Author

The charts sometimes don't update when switching locations on the map.

Has been fixed by removing the debounced on the loading times series ids

@amarkensteijn amarkensteijn marked this pull request as ready for review March 27, 2025 12:38
This needed for the isLoading check in the TimeSeriesChart
@amarkensteijn amarkensteijn force-pushed the 1134-refresh-timeseries branch from 933f020 to e428a9c Compare March 27, 2025 12:40
@amarkensteijn amarkensteijn changed the title 1134 refresh timeseries Automatically refresh timeseries every 30s Mar 27, 2025
@amarkensteijn amarkensteijn changed the title Automatically refresh timeseries every 30s Refresh timeseries automatically every 30s Mar 27, 2025
@amarkensteijn amarkensteijn merged commit 81003a5 into main Mar 27, 2025
8 of 9 checks passed
@amarkensteijn amarkensteijn deleted the 1134-refresh-timeseries branch March 27, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh timeseries
2 participants