Set the mtime fields in the tarball correctly #61
Conversation
This makes FlakeHub flakes behave consistently with GitHub flakes. Unfortunately, this requires a patched tar-rs crate.
| @@ -17,7 +17,8 @@ serde = { version = "1.0.164", features = ["derive"] } | |||
| serde_json = "1.0.97" | |||
| gix = { version = "0.46.0", features = ["async-network-client", "serde"] } | |||
| gix-ref = { version = "0.30.0", features = ["serde"] } | |||
| tar = { version = "0.4.38", features = ["xattr"] } | |||
| #tar = { version = "0.4.38", features = ["xattr"] } | |||
| tar = { git = "https://github.com/DeterminateSystems/tar-rs.git", branch = "force-mtime", features = ["xattr"] } | |||
There was a problem hiding this comment.
Are we planning to try to upstream this? Otherwise, we'll need to keep this in sync somehow (I don't know how active the upstream is but...)
There was a problem hiding this comment.
It's pretty ad hoc. Something more general (e.g. a filter to massage the FS metadata in arbitrary ways) might be more acceptable to upstream.
Upstream is not moving super fast: https://github.com/alexcrichton/tar-rs/tags so I don't think it's a lot of effort to rebase from time to time. It's not like the tar format is changing a lot...
There was a problem hiding this comment.
Let's send a PR anyway and see what they say. We can keep pulling from our fork in the meantime.
There was a problem hiding this comment.
(That is done in alexcrichton/tar-rs#337)
|
Just one question: how will we remember to return to upstream if a change that addresses our need gets merged? |
…m DeterminateSystems/use-coalesce-for-array` (`e8f6e8f54d85aa0fd3d0b694dd3279a21497a33b`)
…d85aa0fd3d0b694dd3279a21497a33b Update `detsys-ts`: Merge pull request #61 from DeterminateSystems/use-coalesce-for-array
This makes FlakeHub flakes behave consistently with GitHub flakes. Unfortunately, this requires a patched tar-rs crate.