Scheduler - Update Templates Demo for jQuery #31605
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the scheduler appointment popup functionality and updates a jQuery demo. The main changes include reordering method calls in the popup initialization, renaming editor name constants for consistency, and completely refactoring the demo's form customization with improved UI.
- Refactored appointment popup form initialization to improve timing and remove redundant toolbar updates
- Updated editor name constants to have an "Editor" suffix for better clarity and consistency
- Redesigned the jQuery Templates demo with a modernized form layout and visual styling
Reviewed Changes
Copilot reviewed 5 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| m_popup.ts | Removed premature updateToolbarForMainGroup() call and moved showMainGroup(false) to after form data is set |
| m_form.ts | Renamed editor name constants to include "Editor" suffix (e.g., startDate → startDateEditor) |
| jQuery/index.js | Complete refactor of form customization with custom template, improved event handling, and modern UI components |
| jQuery/styles.css | Updated styles for the modernized demo with new layout classes and visual improvements |
| jQuery/data.js | Changed movie color palette to softer pastel colors |
packages/devextreme/js/__internal/scheduler/appointment_popup/m_popup.ts
Show resolved
Hide resolved
Signed-off-by: Eldar Iusupzhanov <[email protected]>
| if (canceled) { | ||
| e.cancel = true; | ||
| } else { | ||
| this.updateToolbarForMainGroup(); |
There was a problem hiding this comment.
We are really should remove this line?
There was a problem hiding this comment.
Yep, that's a duplicate invocation of updateToolbarForMainGroup. Because already have this callstack:
_onShowing ->
_updateForm ->
showMainGroup ->
updateToolbarForMainGroup
Sorry for the unrelated change in the PR, but I have noticed it and was afraid that I would forgot about that.
2 participants
No description provided.